Resolving package dependency #957 #1091
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GoSTEAN
commented
Apr 20, 2024
•
GoSTEAN
commented
- Removed any non-essential stuff from abi-wan dependency
- Remove script for js -> ts conversion from abi-wan package and deploy separately to npm
- Script is used with npx is not a default package
- Used same TS versions so npm do not install both [v4.9.5]
|
Need to test this locally |
|
Should be related to this #957 |
|
I can see how this PR will break the CI setup and not provide an alternative, we can't just remove packages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.