Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor test's response schema validation #1151

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

fmmesen
Copy link

@fmmesen fmmesen commented Jun 9, 2024

Motivation and Resolution

#1072
Added JSON RPC Spec schemas for validation and changed those schemas that were the same to RPC to a ref

RPC version (if applicable)

0.7.1

Usage related changes

  • Tests are now using the schemas from JSON RPC Spec directly

Development related changes

  • There is the most recent schemas to validations

Checklist:

  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Linked the issues which this PR resolves
  • Documented the changes in code (API docs will be generated automatically)
  • Updated the tests
  • All tests are passing

@penovicp penovicp merged commit 270b1f2 into starknet-io:develop Jun 20, 2024
3 checks passed
Copy link

🎉 This PR is included in version 6.10.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants