Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Introduce unjs/unbuild #1163

Merged
merged 5 commits into from
Jun 28, 2024

Conversation

b0rza
Copy link
Contributor

@b0rza b0rza commented Jun 27, 2024

It fixes #1137

Motivation and Resolution

Currently, the tsup build tool produces issues in build time when using re-exported same-named values and constants (companion pattern). TLDR: The build output is not correct, which results in correct types, but the constant cannot be recognized by a TS when using the starknet package. So, I introduced unjs/unbuild for cjs and ejs output format.

  • - Add additional unbuild config for cjs and ejs
  • - Configure tsup for iife output format

RPC version (if applicable)

7

Usage related changes

n.a

Development related changes

  • Add unjs/unbuild additional build tool

Checklist:

  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Linked the issues which this PR resolves
  • Documented the changes in code (API docs will be generated automatically)
  • Updated the tests
  • All tests are passing

@b0rza b0rza force-pushed the chore/introduce-unjs-unbuild branch from cb6b1ea to 0ea0af6 Compare June 28, 2024 08:30
@b0rza b0rza marked this pull request as ready for review June 28, 2024 08:30
Copy link
Collaborator

@tabaktoni tabaktoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All test passed on my side
Didn't test IIFE

@tabaktoni tabaktoni merged commit bb4a93d into starknet-io:develop Jun 28, 2024
3 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 28, 2024
## [6.10.1](v6.10.0...v6.10.1) (2024-06-28)

### Bug Fixes

* change build cjs and mjs to unbuild ([#1163](#1163)) ([bb4a93d](bb4a93d))
Copy link

🎉 This PR is included in version 6.10.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problems to use RPCSPEC06 and RPCSPEC07 namespaces
2 participants