Introduced queries for crate plugins in DefsGroup and SemanticGroup

[integraledelebesgue]

Stack:

• Migrated the compiler to per-crate plugin queries #6843
• Introduced default plugin suites to the RootDatabaseBuilder #6852
• Introduced queries for crate plugins in DefsGroup and SemanticGroup #6840 ⬅

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

[reviewable-StarkWare]

This change is 

[orizi]

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @integraledelebesgue)

[mkaput]

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @integraledelebesgue)

---

crates/cairo-lang-defs/src/ids.rs line 359 at r1 (raw file):

}

impl Clone for MacroPluginLongId {

why can't this be derived?

---

crates/cairo-lang-defs/src/ids.rs line 369 at r1 (raw file):

impl PartialEq for MacroPluginLongId {
    fn eq(&self, other: &Self) -> bool {
        *self.0 == *other.0

just pointer equality should be actually enough for us. we already rely on it in LS :)

[integraledelebesgue]

Reviewable status: 1 of 6 files reviewed, 2 unresolved discussions (waiting on @mkaput and @orizi)

---

crates/cairo-lang-defs/src/ids.rs line 359 at r1 (raw file):

Previously, mkaput (Marek Kaput) wrote…

why can't this be derived?

It absolutely can, idk why I thought it couldn't :)

---

crates/cairo-lang-defs/src/ids.rs line 369 at r1 (raw file):

Previously, mkaput (Marek Kaput) wrote…

just pointer equality should be actually enough for us. we already rely on it in LS :)

Done, as we've concluded

[mkaput]

Reviewed 5 of 5 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @orizi and @piotmag769)

[mkaput]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @integraledelebesgue, @orizi, and @piotmag769)

---

crates/cairo-lang-defs/src/db.rs line 107 at r2 (raw file):

    #[salsa::input]
    fn override_crate_macro_plugins(&self, crate_id: CrateId) -> Vec<MacroPluginId>;

etc

Suggestion:

    #[salsa::input]
    fn default_macro_plugins(&self) -> Arc<[MacroPluginId]>;

    #[salsa::input]
    fn override_crate_macro_plugins(&self, crate_id: CrateId) -> Arc<[MacroPluginId]>;

[Draggu]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @integraledelebesgue, @mkaput, @orizi, and @piotmag769)

---

crates/cairo-lang-defs/src/db.rs line 107 at r2 (raw file):

Previously, mkaput (Marek Kaput) wrote…

etc

Apply it to other plugins too.

---

crates/cairo-lang-defs/src/db.rs line 119 at r2 (raw file):

    #[salsa::input]
    fn default_inline_macro_plugins(&self) -> OrderedHashMap<String, InlineMacroExprPluginId>;

Should this be wrapped in Arc? @mkaput

[mkaput]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Draggu, @integraledelebesgue, @orizi, and @piotmag769)

---

crates/cairo-lang-defs/src/db.rs line 119 at r2 (raw file):

Previously, Draggu (Piotr Figiela) wrote…

Should this be wrapped in Arc? @mkaput

yes it should

[integraledelebesgue]

Reviewable status: 4 of 6 files reviewed, 1 unresolved discussion (waiting on @mkaput, @orizi, and @piotmag769)

---

crates/cairo-lang-defs/src/db.rs line 107 at r2 (raw file):

Previously, Draggu (Piotr Figiela) wrote…

Apply it to other plugins too.

Done

[Draggu]

Reviewed 1 of 6 files at r1, 3 of 5 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mkaput, @orizi, and @piotmag769)

[mkaput]

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @orizi and @piotmag769)

[piotmag769]

Reviewed 1 of 6 files at r1, 3 of 5 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @integraledelebesgue and @orizi)

---

crates/cairo-lang-defs/src/db.rs line 101 at r3 (raw file):

    fn macro_plugins(&self) -> Vec<Arc<dyn MacroPlugin>>; // TODO: Delete in favour or [`default_macro_plugins`]
    #[salsa::input] // TODO: Delete in favour or [`default_inline_macro_plugins`]
    fn inline_macro_plugins(&self) -> Arc<OrderedHashMap<String, Arc<dyn InlineMacroExprPlugin>>>;

[nit] Move this lower to group with inline macro methods

[mkaput]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @integraledelebesgue and @orizi)

[mkaput]

Reviewed 2 of 2 files at r4, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @integraledelebesgue, @orizi, and @wawel37)

---

crates/cairo-lang-semantic/src/db.rs line 1625 at r4 (raw file):

/// Initializes the [`SemanticGroup`] database to a proper state.
pub fn init_semantic_group(db: &mut dyn SemanticGroup) {

you have to add calls to all these functions anywhere a database is created. we unfortuately have no compile-time checks for missing initializations, so you need to do a little witch hunt :(

[integraledelebesgue]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @orizi, @piotmag769, and @wawel37)

---

crates/cairo-lang-defs/src/db.rs line 101 at r3 (raw file):

Previously, piotmag769 (Piotr Magiera) wrote…

[nit] Move this lower to group with inline macro methods

That's an old, already present code, that I removed in the last PR. I think it's no use touching it

[mkaput]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @orizi, @piotmag769, and @wawel37)

[orizi]

Reviewed 1 of 2 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @piotmag769 and @wawel37)

[piotmag769]

Reviewed 2 of 2 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @wawel37)

[piotmag769]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @integraledelebesgue and @wawel37)

---

crates/cairo-lang-defs/src/db.rs line 1219 at r4 (raw file):

        plugins: Arc<[MacroPluginId]>,
    ) {
        let mut overrides = self.macro_plugin_overrides().as_ref().clone();

I know this is the way override_file_content is done but is it needed here? Cannot we just modify the arc? cc @mkaput @Draggu