Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pattern #6874

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update pattern #6874

wants to merge 1 commit into from

Conversation

Dahka2321
Copy link

Why needed:

  • Fixed incorrect ref modifier placement
  • Added missing closing brace } for struct pattern
  • Added missing semicolons
  • Completed incomplete expressions

These changes aim to fix basic syntax errors and make the code compilable. However, the exact syntax should be verified against Cairo's official documentation.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @Dahka2321)


a discussion (no related file):
these are parser tests.
please close this PR.

Copy link
Author

@Dahka2321 Dahka2321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Dahka2321)

@Dahka2321
Copy link
Author

@orizi

@Dahka2321 Dahka2321 requested a review from orizi December 24, 2024 13:30
@Dahka2321
Copy link
Author

@orizi
All changes have been implemented according to Cairo's official documentation. Please let me know if anything else needs to be adjusted.

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Dahka2321)


a discussion (no related file):

Previously, orizi wrote…

these are parser tests.
please close this PR.

These are still parser tests.

your changes are not relevant.

close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants