Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected a couple of minor typos #6910

Merged
merged 5 commits into from
Jan 1, 2025
Merged

Conversation

sky-coderay
Copy link
Contributor

Corrected a couple of minor typos . Thanks !

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @sky-coderay)


corelib/src/starknet/storage/sub_pointers.cairo line 4 at r1 (raw file):

/// Similar to storage node, but for structs which are stored sequentially in the storage. In
/// contrast to storage node, the fields of the struct are just offset from the base address of

Suggestion:

/// contrast to storage node, the fields of the struct are just at an offset from the base address of

@sky-coderay
Copy link
Contributor Author

@orizi done

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1, all commit messages.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @sky-coderay)


corelib/src/starknet/storage/sub_pointers.cairo line 19 at r2 (raw file):

        self.sub_pointers()
    }
}я

Suggestion:

}

@sky-coderay
Copy link
Contributor Author

@orizi TXH !

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @sky-coderay)

@orizi orizi enabled auto-merge December 24, 2024 13:45
@sky-coderay
Copy link
Contributor Author

@orizi good ?

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no - your ci is still broken.
run ./scripts/cairo_fmt.sh.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @sky-coderay)

auto-merge was automatically disabled January 1, 2025 15:35

Head branch was pushed to by a user without write access

@sky-coderay
Copy link
Contributor Author

@orizi The PR is ready to merge! Happy New Year.

@orizi orizi enabled auto-merge January 1, 2025 15:42
Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @sky-coderay)

@orizi orizi added this pull request to the merge queue Jan 1, 2025
Merged via the queue into starkware-libs:main with commit be34a58 Jan 1, 2025
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants