-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corrected a couple of minor typos #6910
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @sky-coderay)
corelib/src/starknet/storage/sub_pointers.cairo
line 4 at r1 (raw file):
/// Similar to storage node, but for structs which are stored sequentially in the storage. In /// contrast to storage node, the fields of the struct are just offset from the base address of
Suggestion:
/// contrast to storage node, the fields of the struct are just at an offset from the base address of
@orizi done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1, all commit messages.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @sky-coderay)
corelib/src/starknet/storage/sub_pointers.cairo
line 19 at r2 (raw file):
self.sub_pointers() } }я
Suggestion:
}
@orizi TXH ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @sky-coderay)
@orizi good ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no - your ci is still broken.
run ./scripts/cairo_fmt.sh
.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @sky-coderay)
Head branch was pushed to by a user without write access
@orizi The PR is ready to merge! Happy New Year. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @sky-coderay)
Corrected a couple of minor typos . Thanks !