Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix output formatting in cairo-run #6911

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Hopium21
Copy link

File changed: crates/bin/cairo-run/src/main.rs

Before: first = false; // After print!(", ")
After: first = false; // Before print!(", ")

This PR fixes the output formatting of panic messages in the Cairo runner by moving the first = false assignment before printing the comma separator. This ensures proper comma separation between panic values without an unnecessary leading comma.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @Hopium21)


crates/bin/cairo-run/src/main.rs line 127 at r1 (raw file):

                    print!(", ");
                   }
                first = false;

run ./scripts/rust_fmt.sh

Copy link
Author

@Hopium21 Hopium21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Hopium21)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants