added validation for generic params of impl functions

[TomerStarkware]

No description provided.

[reviewable-StarkWare]

This change is 

[orizi]

Reviewed 1 of 4 files at r1, all commit messages.
Reviewable status: 1 of 4 files reviewed, 1 unresolved discussion (waiting on @TomerStarkware)

---

crates/cairo-lang-semantic/src/items/imp.rs line 3169 at r1 (raw file):

        }
        match (generic_param, trait_generic_param) {
            (GenericParam::Type(_), GenericParam::Type(_)) => {}

we should probably validate names here as well.
(same as we do in non-generic fn params)

Code quote:

            (GenericParam::Type(_), GenericParam::Type(_)) => {}

[TomerStarkware]

Reviewable status: 1 of 4 files reviewed, 1 unresolved discussion (waiting on @orizi)

---

crates/cairo-lang-semantic/src/items/imp.rs line 3169 at r1 (raw file):

Previously, orizi wrote…

we should probably validate names here as well.
(same as we do in non-generic fn params)

isn't it the validation I added in 5 lines above or you mean something else?

[orizi]

Reviewed 2 of 4 files at r1.
Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion (waiting on @TomerStarkware)

---

crates/cairo-lang-semantic/src/items/imp.rs line 3169 at r1 (raw file):

Previously, TomerStarkware wrote…

isn't it the validation I added in 5 lines above or you mean something else?

no - i just missed it.

---

crates/cairo-lang-semantic/src/items/tests/trait line 1302 at r1 (raw file):

//! > ==========================================================================

//! > cycle with anonymous impl with impl alias instead of trait.

this test are deleted?

[TomerStarkware]

Reviewable status: 2 of 4 files reviewed, 1 unresolved discussion (waiting on @orizi)

---

crates/cairo-lang-semantic/src/items/tests/trait line 1302 at r1 (raw file):

Previously, orizi wrote…

this test are deleted?

reverted

[orizi]

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TomerStarkware)