feat(corelib): OptionTrait::map_or, OptionTrait::map_or_else

[julio4]

OptionTrait::map_or

Returns the provided default result (if none), or applies a function to the contained value (if any).

Example

assert_eq!(Option::Some("foo").map_or(42, |v| v.len()), 3);

let x: Option<ByteArray> = Option::None;
assert_eq!(x.map_or(42, |v| v.len()), 42);

OptionTrait::map_or_else

Computes a default function result (if none), or applies a different function to the contained value (if any).

Example

let k = 21;

let x = Option::Some("foo");
assert_eq!(x.map_or_else( || 2 * k, |v: ByteArray| v.len()), 3);

let x: Option<ByteArray> = Option::None;
assert_eq!(x.map_or_else( || 2 * k, |v: ByteArray| v.len()), 42);

[reviewable-StarkWare]

This change is 

[enitrat]

Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @julio4)

---

corelib/src/option.cairo line 356 at r2 (raw file):

    /// or applies a function to the contained value (if any).
    ///
    /// Arguments passed to `map_or` are eagerly evaluated; if you are passing

I don't believe this applies

---

corelib/src/option.cairo line 368 at r2 (raw file):

    ///
    /// let x: Option<ByteArray> = Option::None;
    /// assert_eq!(x.map_or(42, |v| v.len()), 42);

This does not compile

Code quote:

    /// assert_eq!(Option::Some("foo").map_or(42, |v| v.len()), 3);
    ///
    /// let x: Option<ByteArray> = Option::None;
    /// assert_eq!(x.map_or(42, |v| v.len()), 42);

[julio4]

Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @enitrat)

---

corelib/src/option.cairo line 356 at r2 (raw file):

Previously, enitrat (Mathieu) wrote…

I don't believe this applies

Is it different than rust?

---

corelib/src/option.cairo line 368 at r2 (raw file):

Previously, enitrat (Mathieu) wrote…

This does not compile

Done.

[orizi]

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @enitrat and @julio4)

---

a discussion (no related file):
awaiting the other discussion.

[enitrat]

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @julio4)

---

corelib/src/option.cairo line 356 at r2 (raw file):

Previously, julio4 (Julio) wrote…

Is it different than rust?

actually, no, you're right

[enitrat]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @julio4 and @orizi)

---

corelib/src/option.cairo line 368 at r2 (raw file):

Previously, julio4 (Julio) wrote…

Done.

@orizi shouldn't v be automatically inferred as a ByteArray here?

[julio4]

corelib/src/option.cairo line 368 at r2 (raw file):

Previously, enitrat (Mathieu) wrote…

@orizi shouldn't v be automatically inferred as a ByteArray here?

Would love to know as well how the trait bounds inference is currently done

[julio4]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @orizi)

---

a discussion (no related file):

Previously, orizi wrote…

awaiting the other discussion.

Done.

[orizi]

Reviewed 2 of 2 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @julio4)

---

corelib/src/option.cairo line 368 at r2 (raw file):

Previously, julio4 (Julio) wrote…

Would love to know as well how the trait bounds inference is currently done

it should - will make sure to check why it doesn't next week. @TomerStarkware

in general - trait bounds are adding 2 things:

1. An additional assertion that the types match in the call context.
2. Makes the types be used as the exact same type in the function context.

[TomerStarkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @orizi)

[orizi]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @julio4)