Added const for EcPoint including non-zero.

[orizi]

Added actual usage of it in ECDSA - blocked by cfg.

[reviewable-StarkWare]

This change is 

[orizi]

• Added const for EcPoint including non-zero. #8750 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[ilyalesokhin-starkware]

crates/cairo-lang-sierra/src/extensions/modules/const_type.rs line 242 at r2 (raw file):

        return Err(SpecializationError::UnsupportedGenericArg);
    }
    match AffinePoint::new(Felt252::from(x), Felt252::from(y)) {

Does this check if the point is on the curve?

Code quote:

AffinePoint::new(Felt252::from(x), Felt252::from(y))

[ilyalesokhin-starkware]

corelib/src/ecdsa.cairo line 217 at r2 (raw file):

}

#[cfg(sierra: "future")]

what does this do?

Code quote:

cfg(sierra: "future")

[orizi]

Reviewable status: 0 of 5 files reviewed, 2 unresolved discussions (waiting on @ilyalesokhin-starkware and @TomerStarkware)

---

corelib/src/ecdsa.cairo line 217 at r2 (raw file):

Previously, ilyalesokhin-starkware wrote…

what does this do?

just hides the rest of the unused code.

[orizi]

Reviewable status: 0 of 5 files reviewed, 2 unresolved discussions (waiting on @ilyalesokhin-starkware and @TomerStarkware)

---

crates/cairo-lang-sierra/src/extensions/modules/const_type.rs line 242 at r2 (raw file):

Previously, ilyalesokhin-starkware wrote…

Does this check if the point is on the curve?

yes - that is the exact error type.

[ilyalesokhin-starkware]

@ilyalesokhin-starkware reviewed 4 of 4 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TomerStarkware)