Skip to content

Conversation

@cchudant
Copy link
Contributor

Changes

It would be cool to return the finality status when returning events in starknet_getEvents. In fact, I think it's really necessary, otherwise consumers of the jsonrpc API cannot know, when using getEvents for pre-confirmed whether a block is pre-confirmed or confirmed on l2.
In addition, the info about whether the event is on L1 is really nice as well, although if the added complexity in the node implementation is too much, is_preconfirmed: bool replacing this finality status would be sufficient as well.
This also affects websocket subscriptions in #323 - in fact, this is also very useful for the websocket API since it allows you to handle duplicated events properly.

Checklist:

  • Validated the specification files - npm run validate_all
  • Applied formatting - npm run format
  • Performed code self-review
  • If making a new release, checked out the guidelines

(i'm using the github interface for these spec PRs, should I really clone the repo on my machine to test it there and check this checklist?)

@cchudant
Copy link
Contributor Author

Related to #325

@cchudant cchudant changed the title Add finality status to receipts Add finality status to EmittedEvent Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant