Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create blake example that uses GKR for lookups #807

Draft
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

andrewmilson
Copy link
Contributor

@andrewmilson andrewmilson commented Aug 25, 2024

This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2024

Codecov Report

Attention: Patch coverage is 24.19355% with 47 lines in your changes missing coverage. Please review.

Project coverage is 92.60%. Comparing base (14eb2a2) to head (4ab463b).

Files with missing lines Patch % Lines
crates/prover/src/core/lookups/gkr_verifier.rs 9.61% 46 Missing and 1 partial ⚠️
Additional details and impacted files
@@                             Coverage Diff                              @@
##           08-24-Create_MLE_eval_verifier_component     #807      +/-   ##
============================================================================
- Coverage                                     92.95%   92.60%   -0.35%     
============================================================================
  Files                                            89       89              
  Lines                                         12037    12097      +60     
  Branches                                      12037    12097      +60     
============================================================================
+ Hits                                          11189    11203      +14     
- Misses                                          741      787      +46     
  Partials                                        107      107              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewmilson andrewmilson changed the title Create blake component that uses GKR for lookups Create blake example that uses GKR for lookups Aug 25, 2024
@andrewmilson andrewmilson force-pushed the 08-24-Create_MLE_eval_verifier_component branch from eec9cb8 to 2f7ebf2 Compare August 26, 2024 04:16
@andrewmilson andrewmilson force-pushed the 08-25-Create_blake_component_that_uses_GKR_for_lookups branch from 90b629e to 714346f Compare August 26, 2024 04:16
@andrewmilson andrewmilson force-pushed the 08-24-Create_MLE_eval_verifier_component branch from 2f7ebf2 to ddd533f Compare August 26, 2024 04:18
@andrewmilson andrewmilson force-pushed the 08-25-Create_blake_component_that_uses_GKR_for_lookups branch from 714346f to d1436e5 Compare August 26, 2024 04:18
@andrewmilson andrewmilson force-pushed the 08-24-Create_MLE_eval_verifier_component branch from ddd533f to 364bdc2 Compare August 26, 2024 17:45
@andrewmilson andrewmilson force-pushed the 08-25-Create_blake_component_that_uses_GKR_for_lookups branch from d1436e5 to fb1df16 Compare August 26, 2024 17:45
@andrewmilson andrewmilson force-pushed the 08-24-Create_MLE_eval_verifier_component branch from 364bdc2 to 4db6d30 Compare August 27, 2024 04:30
@andrewmilson andrewmilson force-pushed the 08-25-Create_blake_component_that_uses_GKR_for_lookups branch from fb1df16 to c096475 Compare August 27, 2024 04:30
@andrewmilson andrewmilson force-pushed the 08-24-Create_MLE_eval_verifier_component branch from 4db6d30 to 1bca1a7 Compare August 28, 2024 02:03
@andrewmilson andrewmilson force-pushed the 08-25-Create_blake_component_that_uses_GKR_for_lookups branch from c096475 to f484d61 Compare August 28, 2024 02:03
@andrewmilson andrewmilson force-pushed the 08-24-Create_MLE_eval_verifier_component branch from 1bca1a7 to 6d88a87 Compare August 28, 2024 02:11
@andrewmilson andrewmilson force-pushed the 08-25-Create_blake_component_that_uses_GKR_for_lookups branch from f484d61 to 07025b9 Compare August 28, 2024 02:11
@andrewmilson andrewmilson force-pushed the 08-24-Create_MLE_eval_verifier_component branch from 6d88a87 to f06afde Compare August 28, 2024 02:19
@andrewmilson andrewmilson force-pushed the 08-25-Create_blake_component_that_uses_GKR_for_lookups branch from 07025b9 to 18796fa Compare August 28, 2024 02:19
@andrewmilson andrewmilson force-pushed the 08-24-Create_MLE_eval_verifier_component branch from f06afde to 4c9bc7e Compare August 28, 2024 03:07
@andrewmilson andrewmilson force-pushed the 08-25-Create_blake_component_that_uses_GKR_for_lookups branch from 18796fa to bf7a97a Compare August 28, 2024 03:08
@andrewmilson andrewmilson force-pushed the 08-24-Create_MLE_eval_verifier_component branch from 4c9bc7e to 4f24c54 Compare August 28, 2024 03:18
@andrewmilson andrewmilson force-pushed the 08-25-Create_blake_component_that_uses_GKR_for_lookups branch from bf7a97a to a956cef Compare August 28, 2024 03:18
@andrewmilson andrewmilson force-pushed the 08-24-Create_MLE_eval_verifier_component branch from 4f24c54 to fff9df9 Compare August 28, 2024 15:13
@andrewmilson andrewmilson force-pushed the 08-25-Create_blake_component_that_uses_GKR_for_lookups branch from a956cef to 5e93d84 Compare August 28, 2024 15:13
@andrewmilson andrewmilson force-pushed the 08-24-Create_MLE_eval_verifier_component branch from fff9df9 to 35ba7cb Compare September 1, 2024 06:38
@andrewmilson andrewmilson force-pushed the 08-25-Create_blake_component_that_uses_GKR_for_lookups branch from 5e93d84 to ad79e22 Compare September 1, 2024 06:38
@andrewmilson andrewmilson force-pushed the 08-24-Create_MLE_eval_verifier_component branch 2 times, most recently from 5373213 to 4e92911 Compare September 3, 2024 06:18
@andrewmilson andrewmilson force-pushed the 08-25-Create_blake_component_that_uses_GKR_for_lookups branch from ad79e22 to b7cadcf Compare September 3, 2024 06:18
@andrewmilson andrewmilson force-pushed the 08-24-Create_MLE_eval_verifier_component branch from 4e92911 to 14eb2a2 Compare September 9, 2024 07:05
@andrewmilson andrewmilson force-pushed the 08-25-Create_blake_component_that_uses_GKR_for_lookups branch from b7cadcf to 4ab463b Compare September 9, 2024 07:05
Copy link
Collaborator

@shaharsamocha7 shaharsamocha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 28 files at r1, all commit messages.
Reviewable status: 4 of 28 files reviewed, 3 unresolved discussions (waiting on @andrewmilson)


crates/prover/src/constraint_framework/component.rs line 70 at r1 (raw file):

    fn evaluate<E: EvalAtRowWithMle>(&self, eval: E) -> E;
}

Can we move this to the GKR folder?

Code quote:

/// A component defined solely in means of the constraints framework.
/// Implementing this trait introduces implementations for [`Component`] and [`ComponentProver`] for
/// the SIMD backend.
/// Note that the constraint framework only support components with columns of the same size.
pub trait FrameworkEvalWithMle {
    fn log_size(&self) -> u32;

    fn max_constraint_log_degree_bound(&self) -> u32;

    fn evaluate<E: EvalAtRowWithMle>(&self, eval: E) -> E;
}

crates/prover/src/constraint_framework/mod.rs line 101 at r1 (raw file):

trait EvalAtRowWithMle: EvalAtRow {
    fn add_mle_coeff_col_eval(&mut self, eval: Self::EF);
}

same

Code quote:

trait EvalAtRowWithMle: EvalAtRow {
    fn add_mle_coeff_col_eval(&mut self, eval: Self::EF);
}

crates/prover/src/constraint_framework/point.rs line 58 at r1 (raw file):

    }
}

Remove

@andrewmilson andrewmilson force-pushed the 08-24-Create_MLE_eval_verifier_component branch from 14eb2a2 to f1d17af Compare September 24, 2024 01:29
@andrewmilson andrewmilson force-pushed the 08-25-Create_blake_component_that_uses_GKR_for_lookups branch from 4ab463b to 55402a0 Compare September 24, 2024 01:29
@andrewmilson andrewmilson force-pushed the 08-24-Create_MLE_eval_verifier_component branch from f1d17af to a969689 Compare September 24, 2024 01:30
@andrewmilson andrewmilson force-pushed the 08-25-Create_blake_component_that_uses_GKR_for_lookups branch from 55402a0 to 3df0cb9 Compare September 24, 2024 01:30
@andrewmilson andrewmilson force-pushed the 08-24-Create_MLE_eval_verifier_component branch from a969689 to cc6929c Compare October 1, 2024 10:22
Base automatically changed from 08-24-Create_MLE_eval_verifier_component to dev October 1, 2024 10:26
@andrewmilson andrewmilson force-pushed the 08-25-Create_blake_component_that_uses_GKR_for_lookups branch from 3df0cb9 to e56d31e Compare October 30, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants