-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add arithmetic op counts to InfoEvaluator #832
base: dev
Are you sure you want to change the base?
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @andrewmilson and the rest of your teammates on Graphite |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #832 +/- ##
==========================================
+ Coverage 91.91% 91.93% +0.02%
==========================================
Files 90 90
Lines 12375 12548 +173
Branches 12375 12548 +173
==========================================
+ Hits 11374 11536 +162
- Misses 892 901 +9
- Partials 109 111 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
4c79a3d
to
d79f369
Compare
d79f369
to
798f58a
Compare
798f58a
to
a46c994
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 15 files at r1, 14 of 14 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @andrewmilson and @shaharsamocha7)
crates/prover/src/examples/poseidon/mod.rs
line 30 at r3 (raw file):
use crate::core::ColumnVec; const N_LOG_INSTANCES_PER_ROW: usize = 0;
It still works with 3 though, right?
Couldn't see a way to add the counting types without removing
Copy
from a few places.Some constraint code is a bit more ugly now :(
This change is