Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Clone method to StarkProof #884

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

ShuangWu121
Copy link

Description:
This PR adds a Clone implementation for StarkProof. In my current project, I need the ability to duplicate StarkProof instances to simplify reuse in scenarios where moving it once isn’t sufficient. Specifically, I am implementing a prover and want to check the proof as a sanity check inside prover before actually sending the proof to my verifier.

Uncertainty:
I haven’t identified a specific reason why Clone wasn’t implemented initially, and I recognize there might be design considerations or resource management concerns behind that choice. There are potential issues or constraints I might have missed.

Request:
If adding Clone is acceptable within the project’s design, this small change could improve usability for cases like mine. However, if Clone is not desired for any reason, I’m open to finding alternative approaches to handle this in my project—though having Clone would definitely make things easier! 😊

@reviewable-StarkWare
Copy link

This change is Reviewable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants