Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds a
Clone
implementation forStarkProof
. In my current project, I need the ability to duplicateStarkProof
instances to simplify reuse in scenarios where moving it once isn’t sufficient. Specifically, I am implementing a prover and want to check the proof as a sanity check inside prover before actually sending the proof to my verifier.Uncertainty:
I haven’t identified a specific reason why
Clone
wasn’t implemented initially, and I recognize there might be design considerations or resource management concerns behind that choice. There are potential issues or constraints I might have missed.Request:
If adding
Clone
is acceptable within the project’s design, this small change could improve usability for cases like mine. However, ifClone
is not desired for any reason, I’m open to finding alternative approaches to handle this in my project—though havingClone
would definitely make things easier! 😊