Fix execute_ceph_cmd function return code #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function 'execute_ceph_cmd' in ceph_common.sh executes ceph commands and stores the return code in the variable 'errcode'. However, instead of returning this value, the return is always 1. To ensure we know the correct return code for the executed command, the variable `errcode` is returned instead of 1. In addition, the lines in the wlog were also corrected, because if the 'name' variable was empty, the rest of the content would no longer be printed; therefore, double quotes were added to prevent this from happening. Test Plan: - PASS: Run the script and verify that the return code is being returned as expected. - PASS: Check if the logs are being printed correctly. Partial-Bug: https://launchpad.net/bugs/2098031 Signed-off-by: Erickson Silva de Oliveira <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function 'execute_ceph_cmd' in ceph_common.sh executes ceph commands and stores the return code in the variable 'errcode'. However, instead of returning this value, the return is always 1.
To ensure we know the correct return code for the executed command, the variable
errcodeis returned instead of 1.In addition, the lines in the wlog were also corrected, because if the 'name' variable was empty, the rest of the content would no longer be printed; therefore, double quotes were added to prevent this from happening.
Test Plan:
Partial-Bug: https://launchpad.net/bugs/2098031