Adding metrics monitoring using prometheus. #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
+1 from my side, looks good as a dashboard to track the metrics of the STX system. The next steps might be:
Regards Victor R |
saulwold
reviewed
Sep 19, 2019
stx-metrics/monitoring/deployer.py
Outdated
| USERNAME = "jenkins" | ||
| PASSWORD = "jenkins" | ||
|
|
||
| HOST_TARGET = "10.219.115.222" |
Contributor
There was a problem hiding this comment.
Don't publish ip address here, can you find a way to generate it or pass it via a conf file?
Contributor
There was a problem hiding this comment.
good catch, thanks for that !!
Author
There was a problem hiding this comment.
Thanks @saulwold
Actually those were debug global variables and I forgot to delete them. The Config class below in this file gets the configuration data from a yaml file.
I sent the update to delete these three lines.
This is the initial commit for the setup of the infrastructure to gather data from running StarlingX systems. Signed-off-by: Erich Cordoba <[email protected]>
ericho
force-pushed
the
prom-metrics
branch
from
5100c3d to
7bd1d1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the initial commit for the setup of the infrastructure to
gather data from running StarlingX systems.
Signed-off-by: Erich Cordoba [email protected]