Update postprocessing.go to group 'x.com' with 'twitter.com' domains #5637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added the 'x.com' domain to the twitter handle recognition in the performer window. cleans things up a bit with urls. tested, working.
|
It's not really clear to me what this is fixing. The code you changed transforms twitter profile names; if the input string is From my static code inspection, I believe that the only different behaviour is if the input field starts with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added the 'x.com' domain to the twitter handle recognition in the performer window. cleans things up a bit with urls. tested, working.