Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.x] Improve form field accessibility #10993

Open
wants to merge 20 commits into
base: 5.x
Choose a base branch
from
Open

[5.x] Improve form field accessibility #10993

wants to merge 20 commits into from

Commits on Oct 22, 2024

  1. Create unique form field id for templating

    @daun
    daun committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    bdcaabd View commit details
    Browse the repository at this point in the history

  2. Add id attributes to form fields and labels

    @daun
    daun committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    5b31269 View commit details
    Browse the repository at this point in the history

  3. Add unique ids to multi-select inputs

    @daun
    daun committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    8898ef6 View commit details
    Browse the repository at this point in the history

  4. Display field instructions

    @daun
    daun committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    0da35ea View commit details
    Browse the repository at this point in the history

  5. Render field error with id and in red

    @daun
    daun committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    0695728 View commit details
    Browse the repository at this point in the history

  6. Link fields with instructions and error messages

    @daun
    daun committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    2c397e0 View commit details
    Browse the repository at this point in the history

  7. Mark up required fields with aria label

    @daun
    daun committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    de1617d View commit details
    Browse the repository at this point in the history

  8. Collect errors with field handles

    @daun
    daun committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    3f90cdf View commit details
    Browse the repository at this point in the history

  9. Account for fields without forms

    @daun
    daun committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    69617f9 View commit details
    Browse the repository at this point in the history

  10. Render form errors with additional context

    @daun
    daun committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    69a8051 View commit details
    Browse the repository at this point in the history

  11. Remove error rendering additions

    @daun
    daun committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    b7caca7 View commit details
    Browse the repository at this point in the history

  12. Display id first

    @daun
    daun committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    5a5272c View commit details
    Browse the repository at this point in the history

  13. Use session handle as fallback form handle

    @daun
    daun committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    a0de4d0 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. Reorder params of field id helper

    @daun
    daun committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    354660f View commit details
    Browse the repository at this point in the history

  2. Update form render test markup

    @daun
    daun committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    08e8984 View commit details
    Browse the repository at this point in the history

  3. Use predictable test form handle

    @daun
    daun committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    859ea1d View commit details
    Browse the repository at this point in the history

  4. Update form render test cases

    @daun
    daun committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    de4cd19 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2024

  1. Restore dynamic test form handles

    @daun
    daun committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    8f5214d View commit details
    Browse the repository at this point in the history

  2. Allow testing against dynamic form handles

    @daun
    daun committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    206c99e View commit details
    Browse the repository at this point in the history

  3. Add test against form handle in id attributes

    @daun
    daun committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    059a578 View commit details
    Browse the repository at this point in the history