Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.x] Add ArrayableString to Blade value helper #11041

Merged
merged 2 commits into from
Nov 21, 2024
Merged

[5.x] Add ArrayableString to Blade value helper #11041

merged 2 commits into from
Nov 21, 2024

Conversation

ajnsn
Copy link
Contributor

@ajnsn ajnsn commented Nov 1, 2024

Thanks @JohnathonKoster for this neat little value helper 👍

Does it make sense to add the LabeledValue as well?

@jasonvarga jasonvarga changed the title [5.x] Add LabeledValue to Blade value helper [5.x] Add ArrayableString to Blade value helper Nov 21, 2024
@jasonvarga
Copy link
Member

Thanks! I changed it to ArrayableString which will cover more similar situations. (LabeledValue extends ArrayableString).

@jasonvarga jasonvarga merged commit 33b0b13 into statamic:5.x Nov 21, 2024
17 checks passed
@ajnsn ajnsn deleted the add-labeled-value-to-value-helper branch November 22, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonvarga jasonvarga jasonvarga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajnsn @jasonvarga