Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.x] Fix edit form errors after change of term slug #11056

Open
wants to merge 5 commits into
base: 5.x
Choose a base branch
from
Open

[5.x] Fix edit form errors after change of term slug #11056

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1f4fe2e
Send along term edit url
daun Nov 5, 2024
ae0fe98
Send along actions with term resource
daun Nov 5, 2024
0bdefc7
Update actions after save in publish form
daun Nov 5, 2024
55a8f91
Update browser url when term edit url changes
daun Nov 5, 2024
8df3ab7
Remove actions and perform simple redirect
daun Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions resources/js/components/terms/PublishForm.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -503,6 +503,11 @@ export default {
window.location = this.listingUrl;
}

// If the edit URL was changed (i.e. the term slug was updated), redirect them there.
else if (window.location.href !== response.data.data.edit_url) {
window.location = response.data.data.edit_url;
}

// Otherwise, leave them on the edit form and emit an event. We need to wait until after
// the hooks are resolved because if this form is being shown in a stack, we only
// want to close it once everything's done.
Expand Down
Loading