Fix localized seo fields for Eloquent driver users#383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Statamic's Eloquent driver tracks
__localized_fieldson entry save to determine which fields should be included in localized data.Even though
seofield data was being saved, it was not properly showing in the control panel or in front end SEO meta for Eloquent users because the parentseofield was not being tracked by__localized_fields...This PR makes the parent
seofield localizable, so that it can be tracked by__localized_fieldsin Eloquent...Note: Child fields within the seo array were already marked localizable, but this was more for the purpose of making child fields editable, since non-localizable fieldtypes are rendered as read-only inputs in the CP UI. This never affected Stache usage, but the parent
seofield also needs to be localizable for__localized_fieldsas stated above.Fixes #339