Fix untranslatable strings from Redirects & Error Tracking#554
Merged
Conversation
Merged
helloDanuk
added a commit
to helloDanuk/seo-pro
that referenced
this pull request
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where several strings introduced in the Redirects & Error Tracking feature could not be translated.
This was happening because the strings were using the generic
__()helper (e.g.__('Hits')) instead of the addon-namespaced__('seo-pro::messages.hits')format. Without the namespace, Laravel looks for the translations in the app's core language files rather than the addon's language files, making them impossible to translate.This PR fixes it by adding the missing translation keys to
lang/en/messages.phpand updating all references in both Vue components and PHP classes to use theseo-pro::messages.*namespace.Fixes #551
Caused by #545