Skip to content

Hipcub warp threads deprecation #763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Hipcub warp threads deprecation #763

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
673c80b
Changed fetching of warp threads for ROCM
Jul 25, 2025
f135694
Changed comments
Jul 25, 2025
1cad041
Change because device warp size will also be deprecated
Jul 25, 2025
ef8c6ea
Added check for rocm major version to swap between ways of getting WA…
Jul 30, 2025
a495f79
bug fix for HIPCUB_WARP_THREADS
Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions csrc/selective_scan/reverse_scan.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,12 +96,14 @@ struct WarpReverseScan {

/// Whether the logical warp size and the PTX warp size coincide

// In hipcub, warp_threads is defined as HIPCUB_WARP_THREADS ::rocprim::warp_size()
// While in cub, it's defined as a macro that takes a redundant unused argument.
#ifndef USE_ROCM
#define WARP_THREADS CUB_WARP_THREADS(0)
#else
#define WARP_THREADS HIPCUB_WARP_THREADS
#if ROCM_MAJOR_VERSION >= 7
#define WARP_THREADS rocprim::arch::wavefront::max_size()
#else
#define WARP_THREADS HIPCUB_WARP_THREADS
#endif
#endif
static constexpr bool IS_ARCH_WARP = (LOGICAL_WARP_THREADS == WARP_THREADS);
/// The number of warp scan steps
Expand Down
1 change: 1 addition & 0 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,7 @@ def append_nvcc_threads(nvcc_extra_args):
"Refer to the README.md for detailed instructions.",
UserWarning
)
cc_flag.append(f"-DROCM_MAJOR_VERSION={hip_version.major}")

cc_flag.append("-DBUILD_PYTHON_PACKAGE")

Expand Down