add comment about existing issue

statechannels · Oct 12, 2023 · 7a20ca5 · 7a20ca5
1 parent 8f05fc9
commit 7a20ca5
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/.github/workflows/ts-rpc-test.yml b/.github/workflows/ts-rpc-test.yml
@@ -29,11 +29,11 @@ jobs:
         run: make ui/build
 
       - name: Run go-nitro RPC servers with GUI
-        run: go run ./cmd/start-rpc-servers -ui=true &> output.log &
+        run: go run ./cmd/start-rpc-servers -ui=true &> output1.log &
 
       - name: Run Create Channels script
         # TODO: We could write a test specific script that creates channels and checks the results
-        run: npx ts-node ./scripts/client-runner.ts create-channels -w 300000 &> output.log
+        run: npx ts-node ./scripts/client-runner.ts create-channels -w 300000 &> output2.log
         working-directory: packages/nitro-rpc-client
 
       - name: Archive logs

diff --git a/packages/nitro-rpc-client/scripts/client-runner.ts b/packages/nitro-rpc-client/scripts/client-runner.ts
@@ -177,6 +177,7 @@ yargs(hideBin(process.argv))
           yargs.ledgerdeposit
         );
 
+        // race condition means this may never resolve https://github.com/statechannels/go-nitro/issues/1749
         await Promise.all([
           aliceClient.WaitForObjective(aliceLedger.Id),
           bobClient.WaitForObjective(bobLedger.Id),