Minor improvemenets to pk and chainpk test config
#1278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can't use the Required: true API from "github.com/urfave/cli/v2" since that will complain even if the flag is set in a config file. urfave/cli#849 In future we may want to force these keys to be supplied at the command line (best practices would steer away from storing sensitive information in a config file). This commit also enhances the output of the constructor.
4 unique keys for deployer,alice,bob,irene also make stderr colorful
✅ Deploy Preview for nitrodocs canceled.
|
lalexgap
approved these changes
May 12, 2023
lalexgap
reviewed
May 12, 2023
| @@ -121,21 +117,29 @@ func main() { | |||
| Flags: flags, | |||
| Before: altsrc.InitInputSourceWithContext(flags, altsrc.NewTomlSourceFromFlagFunc(CONFIG)), | |||
| Action: func(cCtx *cli.Context) error { | |||
| if pkString == "" { | |||
There was a problem hiding this comment.
I think if we set Required: true when constructing the flag then urfave will handle making sure that a value is provided. (See naaddress)
There was a problem hiding this comment.
Yeah I tried that (see commit messages).
The problem with doing that is, urfave will insist that the flag is set at the command line -- even if it is set in the config toml file.
🧪 Testground Run for fd3e066 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.