Wire up communication related to patches #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Andarist
commented
Feb 1, 2024
Comment on lines
+192
to
+193
| // TODO: consider exposing an object representing a file or a machine to the caller of the `extractMachines` and add a similar-ish method there | ||
| // for now we are just doing through the full extraction process again which is wasteful |
There was a problem hiding this comment.
It's not only wasteful but also incorrect because we need to continue using the same uniqueIds and all. I'm working on this
Andarist
commented
Feb 2, 2024
Andarist
commented
Feb 2, 2024
farskid
approved these changes
Feb 2, 2024
Andarist
force-pushed
the
apply-patches
branch
from
a7b8374 to
fed1d94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.