Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix V3074, V3114 warnings from PVS-Studio Static Analyzer #206

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix V3074, V3114 warnings from PVS-Studio Static Analyzer #206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,4 @@ artifacts
src/CommonAssemblyInfo.cs
*.dotCover
*mm_cache.bin
src/.vs/Fleck/v15/sqlite3/storage.ide
4 changes: 3 additions & 1 deletion src/Fleck/Handlers/Hybi13Handler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,9 @@ public static byte[] FrameData(byte[] payload, FrameType frameType)
}

memoryStream.Write(payload, 0, payload.Length);


memoryStream.Dispose();

return memoryStream.ToArray();
}

Expand Down
2 changes: 1 addition & 1 deletion src/Fleck/Interfaces/ISocket.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

namespace Fleck
{
public interface ISocket
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might be good idea to remove original Dispose() method from this interface as it exists in IDisposable.

public interface ISocket : IDisposable
{
bool Connected { get; }
string RemoteIpAddress { get; }
Expand Down