RequestParser split cookie out of the body to speed up regex match time #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I managed out a simple way to split the cookie out of the header. |
Rosen369
changed the title
|
Nice work. Since the code is walking the whole string, all headers could be parsed in the same way. It would be more generic and give the same performance benefit to any large header, not just Cookie. |
|
Good idea.I will see what I can do. |
|
How about this.Any suggestion? @statianzo |
|
Hi, Any plan for merging this ? @statianzo Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added the unit test in RequestParserTests.cs to test the run time of request with large headers.
Problem reference to #209