Skip to content

chore: uses system nim everywhere #19537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
siddarthkay wants to merge 1 commit into
base: master
Choose a base branch
from
+23 −5
Open

chore: uses system nim everywhere #19537

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion ci/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ ARG QT_VERSION="6.9.2"
ARG QT_MODULES="qtwebchannel qtwebview qtwebsockets qt5compat qtmultimedia qtwebengine qtpositioning qtserialport qtshadertools qtimageformats qtscxml qthttpserver"
ARG LINUXDEPLOYQT_VERSION="20250615-0393b84"
ARG PCSCLITE_VERSION="2.2.3"
ARG NIM_VERSION="2.2.4"

# QT Installation Image --------------------------------------------------------
FROM ubuntu:22.04 AS qt-install
Expand Down Expand Up @@ -46,7 +47,7 @@ RUN cp builddir/pcsclite.h src/PCSC
# Build Image ------------------------------------------------------------------
FROM ubuntu:22.04

ARG QT_VERSION LINUXDEPLOYQT_VERSION PCSCLITE_VERSION
ARG QT_VERSION LINUXDEPLOYQT_VERSION PCSCLITE_VERSION NIM_VERSION

# Adapted from a12e/docker-qt by Aurélien Brooke

Expand Down Expand Up @@ -170,6 +171,22 @@ RUN curl -s https://nixos.org/releases/nix/nix-2.24.11/install | sh -s -- --no-d
# for nix-shell to work
ENV PATH="/home/jenkins/.nix-profile/bin:${PATH}"

# Nim
RUN curl https://nim-lang.org/choosenim/init.sh -sSf | sh -s -- -y \
&& /home/jenkins/.nimble/bin/choosenim ${NIM_VERSION}
ENV PATH="/home/jenkins/.nimble/bin:${PATH}"

# Switch to root to create system-wide symlinks for Nim tools
USER root

RUN ln -sf /home/jenkins/.choosenim/toolchains/nim-${NIM_VERSION}/bin/nim /usr/local/bin/nim \
&& ln -sf /home/jenkins/.choosenim/toolchains/nim-${NIM_VERSION}/bin/nimble /usr/local/bin/nimble \
&& ln -sf /home/jenkins/.choosenim/toolchains/nim-${NIM_VERSION}/bin/choosenim /usr/local/bin/choosenim \
&& chmod 755 /home/jenkins/.choosenim/toolchains/nim-${NIM_VERSION}/bin/* \
&& chown -R root:root /home/jenkins/.choosenim/toolchains/nim-${NIM_VERSION}/bin

USER jenkins

LABEL maintainer="[email protected]"
LABEL source="https://github.com/status-im/status-app"
LABEL description="Build image for the Status Desktop client written in Nim."
2 changes: 1 addition & 1 deletion ci/Jenkinsfile.linux
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ pipeline {
/* Image with Ubuntu 22.04 and QT 6.9.2 */
docker {
label 'linuxcontainer'
image 'harbor.status.im/status-im/status-desktop-build:1.0.5-qt6.9.2'
image 'harbor.status.im/status-im/status-desktop-build:1.0.6-qt6.9.2'
/* allows jenkins use cat and mounts '/dev/fuse' for linuxdeployqt */
args '--entrypoint="" ' +
'--cap-add=SYS_ADMIN ' +
Expand Down
2 changes: 1 addition & 1 deletion ci/Jenkinsfile.tests-nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ pipeline {
agent {
docker {
label 'linuxcontainer'
image 'harbor.status.im/status-im/status-desktop-build:1.0.5-qt6.9.2'
image 'harbor.status.im/status-im/status-desktop-build:1.0.6-qt6.9.2'
}
}

Expand Down
2 changes: 1 addition & 1 deletion scripts/macos_build_setup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ function check_version {

function install_build_dependencies {
echo "Install build dependencies"
brew install pkg-config libtool jq node@22 yarn protoc-gen-go aqtinstall xcbeautify
brew install pkg-config libtool jq node@22 yarn protoc-gen-go aqtinstall xcbeautify nim
}

function install_qt {
Expand Down
1 change: 1 addition & 0 deletions scripts/windows_build_setup.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ function Install-Dependencies {
scoop install --global `
7zip git dos2unix findutils `
wget rcedit inno-setup `
nim mingw-winlibs `
Copy link
Contributor Author

@siddarthkay siddarthkay Dec 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added mingw-winlibs because

Running post_install script...done.
'nim' (2.2.6) was installed successfully!
'nim' suggests installing 'mingw-winlibs'.

make gcc openssl-lts
}

Expand Down
2 changes: 1 addition & 1 deletion vendor/status-go
Open in desktop
Submodule status-go updated 40 files
+1 −2 Makefile
+16 −3 _assets/scripts/migration_check.sh
+9 −4 _assets/scripts/run_functional_tests.sh
+0 −1 api/backend.go
+0 −35 api/backend_test.go
+0 −34 api/geth_backend.go
+1 −1 go.mod
+2 −2 go.sum
+1 −400 messaging/api.go
+87 −0 messaging/api_communities.go
+103 −0 messaging/api_filters.go
+62 −0 messaging/api_installations.go
+22 −0 messaging/api_metrics.go
+54 −0 messaging/api_processor.go
+9 −0 messaging/api_sender.go
+63 −0 messaging/api_store_nodes.go
+64 −0 messaging/api_transport_peers.go
+0 −18 messaging/core.go
+0 −25 mobile/status.go
+1 −1 nix/pkgs/status-go/library/default.nix
+0 −7 node/get_status_node.go
+0 −6 protocol/messenger.go
+3 −3 protocol/messenger_filter_init.go
+0 −10 protocol/messenger_mailserver.go
+0 −5 protocol/messenger_peers.go
+2 −3 protocol/messenger_raw_message_resend.go
+0 −4 services/ext/api.go
+0 −7 services/ext/service.go
+10 −2 services/wallet/thirdparty/activity/alchemy/client.go
+25 −0 services/wallet/thirdparty/activity/alchemy/types.go
+183 −0 services/wallet/thirdparty/activity/alchemy/types_test.go
+26 −0 tests-functional/clients/services/linkpreview.py
+2 −0 tests-functional/clients/status_backend.py
+24 −0 tests-functional/tests/test_link_preview.py
+41 −0 tools/metrics/README.md
+35 −0 tools/metrics/docker-compose.yml
+11 −0 tools/metrics/grafana/provisioning/dashboards/dashboards.yml
+1,599 −0 tools/metrics/grafana/provisioning/dashboards/status-go.json
+11 −0 tools/metrics/grafana/provisioning/datasources/prometheus.yml
+9 −0 tools/metrics/prometheus/prometheus.yml
Loading