Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SendContactRequest popup doesn't show fetched display name #15205

Open
igor-sirotin opened this issue Jun 17, 2024 · 4 comments · May be fixed by #16917
Open

SendContactRequest popup doesn't show fetched display name #15205

igor-sirotin opened this issue Jun 17, 2024 · 4 comments · May be fixed by #16917
Assignees
@jrainville
Labels
bug Something isn't working core-team E:Desktop Contact Requests Anything related to mutual contacts and sending/receiving contact requests goal:core:P0:messaging_active_users
Milestone
2.33.0 Beta

Comments

@igor-sirotin
Copy link
Contributor

igor-sirotin commented Jun 17, 2024 •
edited
Loading

Bug Report

It was definitely working before. And we fixed it a few times already 🙁

Doesn't work for both ENS and non-ENS profiles:

image image
@igor-sirotin igor-sirotin added bug Something isn't working ui-team labels Jun 17, 2024
@igor-sirotin
Copy link
Contributor Author

I guess this should improve with #11983

@jrainville
Copy link
Member

cc @noeliaSD . It's not a huge priority IMO

@noeliaSD noeliaSD added this to the 2.31.0 Beta milestone Jun 18, 2024
@noeliaSD noeliaSD added the E:Desktop Contact Requests Anything related to mutual contacts and sending/receiving contact requests label Jun 18, 2024
@igor-sirotin igor-sirotin changed the title SendContactRequest popup doesn't show ENS name SendContactRequest popup doesn't show fetched disaplay name Jun 19, 2024
@igor-sirotin
Copy link
Contributor Author

It's not only about ENS. Updated the description.

@caybro caybro changed the title SendContactRequest popup doesn't show fetched disaplay name SendContactRequest popup doesn't show fetched display name Sep 20, 2024
@jrainville jrainville modified the milestones: 2.31.0 Beta, 2.32.0 Beta Oct 21, 2024
@jrainville jrainville modified the milestones: 2.32.0 Beta, 2.33.0 Beta Dec 4, 2024
@jrainville jrainville self-assigned this Dec 6, 2024
@jrainville jrainville moved this to In Progress in Status Desktop/Mobile Board Dec 6, 2024
@jrainville
Copy link
Member

I just tested and I can reproduce 100%.

After a restart, it works, so it's for sure a signal that we no longer handle correctly

jrainville added a commit that referenced this issue Dec 6, 2024
@jrainville
fix(contact): fix fetching contact info when sending a CR
2aa7bcc 
Fixes #15205
@jrainville jrainville linked a pull request Dec 6, 2024 that will close this issue
Open
3 tasks
@jrainville jrainville moved this from In Progress to Code Review in Status Desktop/Mobile Board Dec 6, 2024
jrainville added a commit that referenced this issue Dec 12, 2024
@jrainville
fix(contact): fix fetching contact info when sending a CR
94b9924 
Fixes #15205
jrainville added a commit that referenced this issue Dec 18, 2024
@jrainville
fix(contact): fix fetching contact info when sending a CR
a598ddd 
Fixes #15205
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrainville jrainville

Labels
bug Something isn't working core-team E:Desktop Contact Requests Anything related to mutual contacts and sending/receiving contact requests goal:core:P0:messaging_active_users
Projects
Status Desktop/Mobile Board
Status: Code Review
Milestone
2.33.0 Beta
Development

Successfully merging a pull request may close this issue.

fix(contact): fix fetching contact info when sending a CR status-im/status-desktop
5 participants
@iurimatias @Seitseman @jrainville @igor-sirotin @noeliaSD