fix(contact): fix fetching contact info when sending a CR #16917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrainville
requested review from
micieslak,
caybro and
alexjba
as code owners
Jenkins BuildsClick to see older builds (14)
|
jrainville
force-pushed
the
fix/contact-request-missing-display-name
branch
from
2aa7bcc to
94b9924
Compare
|
@micieslak @alexjba friendly reminder to review |
alexjba
reviewed
Dec 13, 2024
|
@jrainville sorry for late review. I don't know how I missed that PR 🤦 |
jrainville
force-pushed
the
fix/contact-request-missing-display-name
branch
from
94b9924 to
a598ddd
Compare
jrainville
force-pushed
the
fix/contact-request-missing-display-name
branch
from
a598ddd to
e915a84
Compare
|
@alexjba @micieslak friendly reminder to review |
alexjba
approved these changes
Jan 8, 2025
|
@alexjba you've been selected as the tester for this |
|
@jrainville Tested! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Fixes #15205
The problem was that we were using the module directly in the Connections, but the store didn't expose it anymore, because it's against the guidelines.
Instead, I moved the Connections to the module to the store itself and the store sends a signal when we have the info.
Affected areas
SendContactRequestModal and ContactsStore (for sending contact requests)
Architecture compliance
My PR is consistent with this document: Status Desktop Architecture Guide
Screenshot of functionality (including design for comparison)
fetch-info.webm
Impact on end user
Fixes the issue
How to test
Risk
Tick one:
Worst case the bug still happens