feat(@desktop/wallet): Move the Account Selector logic to show selected token balance on a specific network to a dedicated WalletAccountsSelectorAdaptor #16834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Khushboo-dev-cpp
requested review from
micieslak,
a team,
caybro and
alexjba
as code owners
Khushboo-dev-cpp
requested review from
Cuteivist
and removed request for
a team
Jenkins BuildsClick to see older builds (53)
|
35 tasks
Khushboo-dev-cpp
force-pushed
the
feat/16705
branch
from
9a3846a to
3a65319
Compare
Khushboo-dev-cpp
changed the base branch from
master
to
feat/buildingSimpleSend
Khushboo-dev-cpp
force-pushed
the
feat/16705
branch
from
3a65319 to
4816285
Compare
Khushboo-dev-cpp
force-pushed
the
feat/buildingSimpleSend
branch
from
56dffde to
017cf6c
Compare
Khushboo-dev-cpp
force-pushed
the
feat/16705
branch
2 times, most recently
from
6a03391 to
3b892d9
Compare
Khushboo-dev-cpp
force-pushed
the
feat/buildingSimpleSend
branch
from
98aeb7e to
16e67a2
Compare
Khushboo-dev-cpp
force-pushed
the
feat/16705
branch
from
3b892d9 to
86c2245
Compare
2 tasks
Khushboo-dev-cpp
force-pushed
the
feat/buildingSimpleSend
branch
4 times, most recently
from
b6919a3 to
a40b6e6
Compare
Khushboo-dev-cpp
force-pushed
the
feat/16705
branch
from
86c2245 to
93d50f5
Compare
alaibe
approved these changes
Jan 6, 2025
Khushboo-dev-cpp
force-pushed
the
feat/16705
branch
2 times, most recently
from
3d46597 to
7f5fe66
Compare
…ed token balance on a sepcific network to a dedicated WalletAccountsSelectorAdaptor fixes #16705
Khushboo-dev-cpp
force-pushed
the
feat/16705
branch
from
1dec9f8 to
6483f38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #16705
What does the PR do
Moves logic to show specific token balance on a specific network to a dedicated WalletAccountsSelectorAdaptor so that it can be reused in the new simple send as well.
Affected areas
SwapModal.qml
Architecture compliance
My PR is consistent with this document: Status Desktop Architecture Guide
Screenshot of functionality (including design for comparison)
Screen.Recording.2024-11-28.at.12.48.11.PM.mov
Screen.Recording.2024-11-28.at.12.47.47.PM.mov