Fixes to pinned messages #16894
Merged
Fixes to pinned messages #16894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrainville
requested review from
glitchminer,
a team,
iurimatias,
osmaczko and
saledjenic
and removed request for
a team
Jenkins BuildsClick to see older builds (14)
|
jrainville
force-pushed
the
fix/pinned-messages-edits
branch
2 times, most recently
from
a571ed3 to
0402861
Compare
|
@iurimatias @osmaczko @saledjenic friendly reminder to review |
saledjenic
approved these changes
Dec 16, 2024
| @@ -3,7 +3,7 @@ import NimQml | |||
| import ../item as chat_item | |||
| import ../../../../../app_service/service/message/dto/pinned_message | |||
| import ../../../../../app_service/service/chat/dto/chat | |||
|
|
|||
| import ../../../../../app_service/service/message/dto/message | |||
There was a problem hiding this comment.
@jrainville you could go without ../../../../../, actually you can remove those prefixes from every line here, but even if not, we can live with that. ;)
jrainville
force-pushed
the
fix/pinned-messages-edits
branch
from
0402861 to
86a6d48
Compare
alaibe
approved these changes
Dec 17, 2024
|
@saledjenic you were randomly chosen to be the tester for this fix. Thanks
|
osmaczko
approved these changes
Dec 18, 2024
iurimatias
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Fixes #16639
Affected areas
Pins
Screenshot of functionality (including design for comparison)
pin-fixes.webm
Impact on end user
Fixes some scenarios of using pinned messages
How to test
Risk
Tick one:
Worst case is issue still happens