feat(channel): show channels with unread messages even if collapsed #17017
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #17016 Sets the channel as visible when it has unread messages, but not muted, or has a notification (reply or mention) or it's active, even when collapsed.
jrainville
requested review from
micieslak,
caybro and
alexjba
as code owners
Jenkins Builds
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Fixes #17016
Sets the channel as visible when it has unread messages, but not muted, or has a notification (reply or mention) or it's active, even when collapsed.
Affected areas
Channel list (only for communities)
Architecture compliance
My PR is consistent with this document: Status Desktop Architecture Guide
Screenshot of functionality
Unread messages (shows even if it's collapsed):
Active channel (shows even if read and collapsed):
Muted channel (doesn't show):
Muted but it's a notification (shows even if muted and collapsed):
Impact on end user
Makes it easier to manage a community with a lot of channels. Currently, it's not useful to collapse unmuted categories, because then when you have messages in a collapsed channel, you have to manually open the category to see which channel it is.
With this small change, it's now easy to know which channel it is and only one click to see the unread messages.
How to test
Risk
Tick one:
Worst case, the feature doesn't work in some edge scenario