fix(ac): fix review CR popup not showing correct data from the AC #17018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #16601 The original issue of seeing ` ` was already fixed, but the popup, when opening from the activity center didn't have any spaces. However, when displayed from the profile, everything showed fine. So the fix was simply to remove the old way of opening from the AC and use the same call that is used in the profile popup.
jrainville
requested review from
micieslak,
caybro and
alexjba
as code owners
Jenkins Builds
|
alexjba
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Fixes #16601
The original issue of seeing
was already fixed, but the popup, when opening from the activity center didn't have any spaces. However, when displayed from the profile, everything showed fine. So the fix was simply to remove the old way of opening from the AC and use the same call that is used in the profile popup.Affected areas
Review contact request popup (when opened from the AC)
Architecture compliance
My PR is consistent with this document: Status Desktop Architecture Guide
Screenshot of functionality
Impact on end user
Fixes the issue with spaces not working in the popup
How to test
Everything should look ok
Risk
Tick one:
Worst case the spaces look weird still