feat(@desktop/privacyMode): Added missing files for mobile screens #18952
+280
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (37)
|
Khushboo-dev-cpp
changed the title
Khushboo-dev-cpp
force-pushed
the
feat/finishingUpPrivacyMode
branch
from
bab349e to
9fd5cd1
Compare
Khushboo-dev-cpp
requested review from
a team,
alexjba,
caybro,
micieslak and
noeliaSD
as code owners
caybro
reviewed
Oct 6, 2025
alexjba
reviewed
Oct 7, 2025
Screen_Recording_20251007_104158_Status-tablet.mp4The third image has a different height and the view content jumps around |
@alexjba the issue is caused by the longer text for collectibles its not because of the image. |
Ahh, right! Can we move the text up instead of moving the entire content down? |
Khushboo-dev-cpp
force-pushed
the
feat/finishingUpPrivacyMode
branch
from
9fd5cd1 to
0aaba80
Compare
… light and dark mode + desktop dark mode of placeholders when ThirdParty services are disabled
Khushboo-dev-cpp
force-pushed
the
feat/finishingUpPrivacyMode
branch
from
0aaba80 to
0395d2e
Compare
Record_2025-10-13-19-33-13.mp4fixed. :) |
thirdparty services are disbaled and the check when loggin in which used fedoraporject
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Affected areas
Architecture compliance
My PR is consistent with this document: QML Architecture Guidelines
Screencapture of the functionality
Desktop
Screen.Recording.2025-10-06.at.10.52.38.mov
Mobile
Screen.Recording.2025-10-06.at.10.54.04.mov
Browser:
Screen.Recording.2025-10-13.at.16.17.02.mov
Trying to monitor web calls after thrid party services are disabled
MailVideo.mov
Impact on end user
How to test
Risk