e2e appium/test settings password change password #18977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
password change test ported from desktop e2e
Jenkins BuildsClick to see older builds (22)
|
anastasiyaig
reviewed
Oct 9, 2025
test/e2e_appium/tests/test_settings_password_change_password.py
Outdated
Show resolved
Hide resolved
anastasiyaig
reviewed
Oct 9, 2025
test/e2e_appium/tests/test_settings_password_change_password.py
Outdated
Show resolved
Hide resolved
anastasiyaig
reviewed
Oct 9, 2025
test/e2e_appium/tests/test_settings_password_change_password.py
Outdated
Show resolved
Hide resolved
anastasiyaig
reviewed
Oct 9, 2025
test/e2e_appium/tests/test_settings_password_change_password.py
Outdated
Show resolved
Hide resolved
anastasiyaig
reviewed
Oct 9, 2025
test/e2e_appium/tests/test_settings_password_change_password.py
Outdated
Show resolved
Hide resolved
anastasiyaig
reviewed
Oct 9, 2025
test/e2e_appium/tests/test_settings_password_change_password.py
Outdated
Show resolved
Hide resolved
anastasiyaig
reviewed
Oct 9, 2025
|
|
||
| def generate_secure_password(length: int = 16) -> str: | ||
| """Generate a strong password that meets basic complexity requirements.""" | ||
| length = max(length, 12) |
There was a problem hiding this comment.
are we sure that length is 12? on desktop it is 100, worth checking why mobile has that short password if thats the case
There was a problem hiding this comment.
This just generates a valid password, it's not the maximum allowed. I would rather use a lower number in this test until we have more reliable and faster ways to update fields - the current input method is entering each character individually.
There was a problem hiding this comment.
roger that , makes sense
anastasiyaig
reviewed
Oct 9, 2025
anastasiyaig
approved these changes
Oct 9, 2025
|
pls squash commits before merging |
noeliaSD
approved these changes
Oct 14, 2025
| if overlay and ElementStateChecker.is_displayed(overlay): | ||
| try: | ||
| rect = overlay.rect | ||
| tap_x = int(rect.get("x", 0) + rect.get("width", 0) * 0.25) |
There was a problem hiding this comment.
Why do we need this manual positioning?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Password change test ported from desktop e2e to mobile
Tested on local and lambdatest
test_change_password_and_login.mp4