fix(@desktop/biometrics): Simplified user flow for enabling/disabling biometric login from settings screen. #19034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Khushboo-dev-cpp
requested review from
a team,
alexjba,
caybro,
micieslak and
noeliaSD
as code owners
Jenkins BuildsClick to see older builds (19)
|
alexjba
approved these changes
Oct 17, 2025
biometric login from settings screen. Also change treatment of user cancelled event on android to Cancelled from Genric Error fixes #19011
Khushboo-dev-cpp
force-pushed
the
fix/19011
branch
from
e92eeaa to
56e85bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also change treatment of user cancelled event on android to Cancelled from Genric Error
fixes #19011, fixed #18996
What does the PR do
Affected areas
Bioemtric Login
Password Settings
Architecture compliance
My PR is consistent with this document: QML Architecture Guidelines
Screencapture of the functionality
IOS Biometrics settings
https://github.com/user-attachments/assets/d1ce1565-0305-4a89-b57d-f23b743a3d05
IOS Cancel Biometrics flow
https://github.com/user-attachments/assets/2eb47baa-1177-40d6-8387-e9c08af8bdfc
Android Biometrics settings
https://github.com/user-attachments/assets/8bb040a0-d5f9-4c82-ae15-46e33d6c4f47
Impact on end user
How to test
Risk