Skip to content

Conversation

igor-sirotin
Copy link
Contributor

@igor-sirotin igor-sirotin commented Oct 19, 2025

Requires:

  1. Removed some unused methods
  2. Removed nil context argument, as it has changed in status-go
  3. Removed installation of mockgen and go-bindata, as they're now used with go tool ...

@igor-sirotin igor-sirotin requested review from a team as code owners October 19, 2025 10:30
@igor-sirotin igor-sirotin requested review from jrainville and osmaczko and removed request for a team October 19, 2025 10:30
@igor-sirotin igor-sirotin self-assigned this Oct 19, 2025
@status-im-auto
Copy link
Member

status-im-auto commented Oct 19, 2025

Jenkins Builds

Click to see older builds (8)
Commit #️⃣ Finished (UTC) Duration Platform Result
94761e6 #1 2025-10-19 10:37:34 ~6 min macos/aarch64 📄log
✔️ 94761e6 #1 2025-10-19 10:39:03 ~7 min tests/nim 📄log
✔️ 94761e6 #1 2025-10-19 10:41:22 ~10 min ios/aarch64 📦pkg
✔️ 94761e6 #1 2025-10-19 10:44:15 ~13 min tests/ui 📄log
✔️ 94761e6 #1 2025-10-19 10:47:55 ~16 min linux/x86_64 📦tgz
✔️ 94761e6 #1 2025-10-19 10:54:25 ~23 min linux/x86_64-nwaku 📦tgz
✔️ 94761e6 #1 2025-10-19 10:57:02 ~25 min windows/x86_64 💿exe
✔️ 94761e6 pr19077 2025-10-19 11:04:59 ~16 min tests/e2e 📊rpt
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 210bdbc #2 2025-10-20 12:00:37 ~7 min ios/aarch64 📦pkg
✔️ 210bdbc #2 2025-10-20 12:00:46 ~7 min tests/nim 📄log
✔️ 210bdbc #1 2025-10-20 12:02:43 ~9 min android/arm64 🤖apk 📲
✔️ 210bdbc #2 2025-10-20 12:06:54 ~13 min tests/ui 📄log
✔️ 210bdbc #2 2025-10-20 12:09:31 ~16 min linux/x86_64 📦tgz
✔️ 210bdbc #2 2025-10-20 12:15:39 ~22 min linux/x86_64-nwaku 📦tgz
✔️ 210bdbc #2 2025-10-20 12:18:13 ~24 min windows/x86_64 💿exe
✔️ 210bdbc #2 2025-10-20 12:20:31 ~27 min macos/aarch64-nwaku 🍎dmg
✔️ 210bdbc pr19077 2025-10-20 12:28:44 ~19 min tests/e2e 📊rpt
✔️ 210bdbc #5 2025-10-21 04:25:37 ~9 min macos/aarch64 🍎dmg
✔️ 2b67f1cb #2 2025-10-20 17:26:44 ~11 min android/arm64 🤖apk 📲

Copy link
Member

@caybro caybro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@igor-sirotin igor-sirotin force-pushed the chore/remove-unused-methods branch from 94761e6 to 210bdbc Compare October 20, 2025 11:53
@igor-sirotin igor-sirotin merged commit 2cb8dfe into master Oct 21, 2025
12 checks passed
@igor-sirotin igor-sirotin deleted the chore/remove-unused-methods branch October 21, 2025 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants