feat(telemetry)_: track dial errors #5859
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (25)
|
adklempner
force-pushed
the
feat/telemetry-dial-error
branch
5 times, most recently
from
efb1cab to
ce80682
Compare
adklempner
force-pushed
the
feat/telemetry-dial-error
branch
from
ce80682 to
ed55657
Compare
|
Closing in favor of #5899 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Listen for dial failure events emitted by go-waku and send to telemetry.
Adds a helper function for parsing dial error strings into a structured type.
If telemetry is enabled, create a subscription to
DialErrorevents emitted in theEventBusby go-waku. Parse the error message in the event using the helper function. Push each parsed error to the telemetry client.Important changes:
Related to status-im/telemetry#21