Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(wallet)_: fees factor updated #6156

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

saledjenic
Copy link
Contributor

@saledjenic saledjenic commented Dec 2, 2024

New factors:
lowFeeFactor = 1
mediumFeeFactor = 1.2
highFeeFactor = 2

@status-im-auto
Copy link
Member

status-im-auto commented Dec 2, 2024

Jenkins Builds

Click to see older builds (8)
Commit #️⃣ Finished (UTC) Duration Platform Result
✖️ ab6d04d #1 2024-12-02 15:58:05 ~5 min tests-rpc 📄log
✔️ ab6d04d #1 2024-12-02 15:58:05 ~5 min windows 📦zip
✔️ ab6d04d #1 2024-12-02 15:58:15 ~5 min ios 📦zip
✔️ ab6d04d #1 2024-12-02 15:58:24 ~5 min macos 📦zip
✔️ ab6d04d #1 2024-12-02 15:58:30 ~5 min linux 📦zip
✔️ ab6d04d #1 2024-12-02 15:58:30 ~5 min android 📦aar
✔️ ab6d04d #1 2024-12-02 15:59:10 ~6 min macos 📦zip
✔️ ab6d04d #1 2024-12-02 16:23:08 ~30 min tests 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 8cee287 #3 2024-12-02 16:03:07 ~3 min windows 📦zip
✔️ 8cee287 #2 2024-12-02 16:05:26 ~6 min macos 📦zip
✔️ 8cee287 #3 2024-12-02 16:09:00 ~4 min macos 📦zip
✖️ 8cee287 #3 2024-12-02 16:09:08 ~4 min tests-rpc 📄log
✔️ 8cee287 #3 2024-12-02 16:09:58 ~4 min ios 📦zip
✔️ 8cee287 #3 2024-12-02 16:10:42 ~5 min linux 📦zip
✔️ 8cee287 #3 2024-12-02 16:10:55 ~5 min android 📦aar
✔️ 8cee287 #3 2024-12-02 16:11:44 ~6 min macos 📦zip
✔️ 8cee287 #2 2024-12-02 16:54:15 ~31 min tests 📄log
✖️ 987a9b0 #2 2024-12-02 16:04:10 ~5 min tests-rpc 📄log
✔️ 987a9b0 #2 2024-12-02 16:04:33 ~5 min macos 📦zip
✔️ 987a9b0 #2 2024-12-02 16:04:45 ~5 min linux 📦zip
✔️ 987a9b0 #2 2024-12-02 16:04:50 ~5 min android 📦aar
✔️ 987a9b0 #2 2024-12-02 16:04:55 ~6 min ios 📦zip

@saledjenic saledjenic force-pushed the feat/update-fees-factor branch from ab6d04d to 987a9b0 Compare December 2, 2024 15:58
New factors:
lowFeeFactor = 1
mediumFeeFactor = 1.2
highFeeFactor = 2
@saledjenic saledjenic force-pushed the feat/update-fees-factor branch from 987a9b0 to 8cee287 Compare December 2, 2024 15:59
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 59.94%. Comparing base (7a967e1) to head (8cee287).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
services/wallet/router/fees/fees.go 0.00% 17 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6156      +/-   ##
===========================================
- Coverage    60.91%   59.94%   -0.98%     
===========================================
  Files          827      827              
  Lines       109702   109713      +11     
===========================================
- Hits         66826    65765    -1061     
- Misses       35041    36205    +1164     
+ Partials      7835     7743      -92     
Flag Coverage Δ
functional 0.00% <0.00%> (-13.78%) ⬇️
unit 59.99% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
services/wallet/router/fees/fees.go 19.35% <0.00%> (-15.37%) ⬇️

... and 73 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants