feat(telem)_: track raw message by type on send #6176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (150)
|
adklempner
force-pushed
the
feat/telem-message-by-type
branch
2 times, most recently
from
76e8d11 to
9009d00
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6176 +/- ##
============================================
- Coverage 61.27% 19.30% -41.98%
============================================
Files 833 811 -22
Lines 109910 107929 -1981
============================================
- Hits 67348 20832 -46516
- Misses 34711 84266 +49555
+ Partials 7851 2831 -5020
Flags with carried forward coverage won't be shown. Click here to find out more.
|
adklempner
force-pushed
the
feat/telem-message-by-type
branch
2 times, most recently
from
055bb1d to
c4644e7
Compare
adklempner
changed the title
adklempner
force-pushed
the
feat/telem-message-by-type
branch
11 times, most recently
from
d94dea8 to
94a5792
Compare
adklempner
changed the title
adklempner
force-pushed
the
feat/telem-message-by-type
branch
3 times, most recently
from
ebced90 to
7a3315a
Compare
adklempner
force-pushed
the
feat/telem-message-by-type
branch
from
7a3315a to
2e23870
Compare
plopezlpz
reviewed
Jan 2, 2025
| @@ -227,6 +228,7 @@ type NewMessage struct { | |||
| // Post posts a message on the Waku network. | |||
| // returns the hash of the message in case of success. | |||
| func (api *PublicWakuAPI) Post(ctx context.Context, req NewMessage) (hexutil.Bytes, error) { | |||
| logutils.ZapLogger().Info("AK Post", zap.String("stack", string(debug.Stack()))) | |||
There was a problem hiding this comment.
this might log a lot, consider removing or changing the log level to trace (or something like that)
plopezlpz
reviewed
Jan 2, 2025
| @@ -52,6 +53,14 @@ func (tmc *testMessengerConfig) complete() error { | |||
| return nil | |||
| } | |||
|
|
|||
| type mockTelemetryService struct{} | |||
|
|
|||
| func (m *mockTelemetryService) PushRawMessageByType(ctx context.Context, msg struct { | |||
There was a problem hiding this comment.
I don't know if we are recording telemetry when sending other individual messages, if we do then just including message type and size to those would be enought, right?(maybe not since it might be in another part of the code without this info). Can we include pubsub topic and content topic here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sends raw message type and payload size to telemetry before sending a message using sender or data sync
Adds a reference to telemetry service to message sender
If telemetry is enabled, metric is sent anytime
transport.Trackors.addToDataSyncis called inmessage_senderAlso sent in messenger upon
sendDataSyncImportant changes:
Closes #