Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#20434] Allow users from v1 to login with keycard #20558

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[#20434] Allow users from v1 to login with keycard #20558

wants to merge 1 commit into from
+858 −457

Conversation

flexsurfer
Copy link
Member

@flexsurfer flexsurfer commented Jun 25, 2024 •
edited
Loading

fixes: #20434
fixes: #18470

Steps to test:

  1. Install PR version of 1.20.x
  2. create keycard account
  3. install this PR on top
  4. try to login with keycard

Unfortunately I wasn't able to test on ios device

NOTE:
REVERT BEFORE MERGE android version!

@status-github-bot status-github-bot bot added this to REVIEW in Pipeline for QA Jun 25, 2024
@status-im-auto
Copy link
Member

status-im-auto commented Jun 25, 2024 •
edited
Loading

Jenkins Builds

Click to see older builds (12)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ cd3cc08 #1 2024-06-25 10:59:14 ~4 min tests 📄log
❌ cd3cc08 #1 2024-06-25 11:01:39 ~6 min android-e2e 📄log
❌ cd3cc08 #1 2024-06-25 11:01:49 ~6 min android 📄log
❌ cd3cc08 #1 2024-06-25 11:03:35 ~8 min ios 📄log
❌ 1476f55 #2 2024-06-25 11:17:42 ~3 min tests 📄log
✔️ 1476f55 #2 2024-06-25 11:22:18 ~8 min android-e2e 🤖apk 📲
✔️ 1476f55 #2 2024-06-25 11:22:22 ~8 min android 🤖apk 📲
✔️ 1476f55 #2 2024-06-25 11:22:33 ~8 min ios 📱ipa 📲
❌ 141c1a3 #3 2024-06-26 08:40:56 ~3 min tests 📄log
✔️ 141c1a3 #3 2024-06-26 08:43:40 ~6 min android-e2e 🤖apk 📲
✔️ 141c1a3 #3 2024-06-26 08:44:29 ~7 min android 🤖apk 📲
✔️ 141c1a3 #3 2024-06-26 08:45:56 ~8 min ios 📱ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 189d3c6 #4 2024-06-26 09:07:36 ~4 min tests 📄log
✔️ 189d3c6 #4 2024-06-26 09:10:30 ~7 min android-e2e 🤖apk 📲
✔️ 189d3c6 #4 2024-06-26 09:10:32 ~7 min android 🤖apk 📲
✔️ 189d3c6 #4 2024-06-26 09:12:04 ~8 min ios 📱ipa 📲
✔️ fcb06ee #5 2024-06-27 07:15:51 ~4 min tests 📄log
✔️ fcb06ee #5 2024-06-27 07:19:45 ~8 min android-e2e 🤖apk 📲
✔️ fcb06ee #5 2024-06-27 07:19:48 ~8 min android 🤖apk 📲
✔️ fcb06ee #6 2024-06-27 07:53:43 ~15 min ios 📱ipa 📲

@flexsurfer flexsurfer changed the title [WIP] [#20434] Allow users from v1 to login with keycard [#20434] Allow users from v1 to login with keycard Jun 26, 2024
@flexsurfer flexsurfer self-assigned this Jun 26, 2024
flexsurfer
flexsurfer commented Jun 26, 2024
View reviewed changes
android/gradle.properties
@@ -45,7 +45,7 @@ ANDROID_ABI_INCLUDE=armeabi-v7a;arm64-v8a;x86;x86_64

org.gradle.jvmargs=-Xmx8704M -XX:+UseParallelGC

versionCode=9999
versionCode=2024052414
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

REVERT BEFORE MERGE!

flexsurfer
flexsurfer commented Jun 26, 2024
View reviewed changes
src/status_im/contexts/keycard/sheet/view.cljs
[status-im.common.resources :as resources]
[utils.re-frame :as rf]))

(defn connect-keycard
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we just need a temporary solution, so no styles and i18n

Parveshdhull
Parveshdhull approved these changes Jun 26, 2024
View reviewed changes
src/status_im/subs/keycard.cljs
:keycard/pin-retry-counter
(fn [db]
(get-in db [:keycard :application-info :pin-retry-counter])))

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty line

src/status_im/contexts/preview/quo/pin_input/pin_input.cljs
Comment on lines +6 to +7


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty line

src/status_im/contexts/keycard/utils.cljs
Comment on lines +39 to +42
(and (zero? pin-retry-counter)
(or (nil? puk-retry-counter)
(pos? puk-retry-counter)))
nil
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

redundant?

@flexsurfer flexsurfer moved this from REVIEW to E2E Tests in Pipeline for QA Jun 26, 2024
@status-im-auto
Copy link
Member

82% of end-end tests have passed

Total executed tests: 51
Failed tests: 5
Expected to fail tests: 4
Passed tests: 42

IDs of failed tests: 727230,727229,703202,702839,702731 

IDs of expected to fail tests: 703495,702948,727232,703629

Failed tests (5)

Click to expand
  • Rerun failed tests

    • Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_reactions, id: 703202

    Device 3: Element EmojisNumber text is equal to 1
    Device 2: Element EmojisNumber text is equal to 1 

    critical/chats/test_group_chat.py:125: in test_group_chat_reactions
    self.loop.run_until_complete(run_in_parallel((
/usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete
    return future.result()
__init__.py:52: in run_in_parallel
    returns.append(await k)
/usr/lib/python3.10/concurrent/futures/thread.py:58: in run
    result = self.fn(*self.args, **self.kwargs)
critical/chats/test_group_chat.py:122: in _check_reactions_count
    chat_element.emojis_below_message(emoji="love").wait_for_element_text(1)
../views/base_element.py:181: in wait_for_element_text
    element_text = self.find_element().text.strip()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: EmojisNumber by xpath: `//*[starts-with(@text,'This is a test message to check some reactions.')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']/../..//*[@content-desc='emoji-reaction-1']/android.widget.TextView[2]` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_pin_messages, id: 702731

    Device 1: Find Button by xpath: //*[@content-desc='pins-count']//android.widget.TextView
    Device 1: Find Button by xpath: //*[@content-desc='pins-count']//android.widget.TextView 

    critical/chats/test_1_1_public_chats.py:198: in test_1_1_chat_pin_messages
    chat.pinned_messages_count.wait_for_element_text(text="2",
../views/base_element.py:190: in wait_for_element_text
    self.driver.fail(message if message else "`%s` is not equal to expected `%s` in %s sec" % (
base_test_case.py:178: in fail
    pytest.fail('Device %s: %s' % (self.number, text))
 Device 1: Pinned messages count is not 2 as expected!



    Device sessions

    Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230

    # STEP: Getting ETH amount in the wallet of the sender before transaction
    Device 1: Find WalletTab by accessibility id: wallet-stack-tab 

    critical/test_wallet.py:152: in test_wallet_send_asset_from_drawer
    sender_balance, receiver_balance, eth_amount_sender, eth_amount_receiver = self._get_balances_before_tx()
critical/test_wallet.py:40: in _get_balances_before_tx
    self.wallet_1.wallet_tab.click()
../views/base_element.py:90: in click
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: WalletTab by accessibility id: `wallet-stack-tab` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    2. test_wallet_send_eth, id: 727229

    Device 1: Swiping right on element SlideButton
    Device 1: Find SlideButton by xpath: //*[@resource-id='slide-button-track'] 

    critical/test_wallet.py:132: in test_wallet_send_eth
    self.wallet_1.send_asset(address=self.receiver['wallet_address'], asset_name='Ether', amount=amount_to_send)
../views/wallet_view.py:130: in send_asset
    self.confirm_transaction()
../views/wallet_view.py:118: in confirm_transaction
    self.slide_and_confirm_with_password()
../views/wallet_view.py:112: in slide_and_confirm_with_password
    self.slide_button_track.slide()
../views/base_view.py:257: in slide
    self.swipe_right_on_element(width_percentage=1.3, start_x=100)
../views/base_element.py:308: in swipe_right_on_element
    location, size = self.get_element_coordinates()
../views/base_element.py:294: in get_element_coordinates
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: SlideButton by xpath: `//*[@resource-id='slide-button-track']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_delete, id: 702839

    Device 2: Tap on found: SendMessageButton
    Device 1: Looking for a message by text: delete for me 

    critical/chats/test_public_chat_browsing.py:401: in test_community_message_delete
    self.channel_1.chat_element_by_text(message_to_delete_for_me).wait_for_element(120)
../views/base_element.py:129: in wait_for_element
    raise TimeoutException(
 Device `1`: `ChatElementByText` by` xpath`: `//*[starts-with(@text,'delete for me')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_element



    Device sessions

    Expected to fail tests (4)

    Click to expand

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_hashtag_links_to_community_channels, id: 702948

    Device 2: Find Text by xpath: //android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView[contains(@text,'#cats')]
    Device 2: Looking for a message by text: it is just a message text 

    critical/chats/test_public_chat_browsing.py:1124: in test_community_hashtag_links_to_community_channels
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message in community channel is not visible for user before join

    [[Can't enter channel after community is fetched for the first time, https://github.com//issues/20395]]

    Device sessions

    2. test_community_join_when_node_owner_offline, id: 703629

    Device 2: Looking for community: 'open community'
    Device 2: Click until Text by accessibility id: community-description-text will be presented 

    critical/chats/test_public_chat_browsing.py:1212: in test_community_join_when_node_owner_offline
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message in community channel is not visible for user before join, it was indicated as not sent for the sender before he went offline

    [[Can't enter channel after community is fetched for the first time, https://github.com//issues/20395]]

    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_mute_chat, id: 703495

    # STEP: Change device time so chat will be unmuted by timer
    Device 2: Long press on ChatElement 

    critical/chats/test_group_chat.py:497: in test_group_chat_mute_chat
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Chat is still muted after timeout

    [[Chat is not unmuted after expected time: https://github.com//issues/19627]]

    Device sessions

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_watch_only_account, id: 727232

    Device 1: Text is 0x8d2413447ff297d30bdc475f6d5cb00254685aae
    Device 1: Click system back button 

    critical/test_wallet.py:256: in test_wallet_add_remove_watch_only_account
    self.home_view.driver.fail(
base_test_case.py:178: in fail
    pytest.fail('Device %s: %s' % (self.number, text))
 Device 1: Incorrect address '0x8d2413447ff297d30bdc475f6d5cb00254685aae' is shown when swiping between accounts, expected one is '0x8d2413447ff297d30bdc475f6d5cb00254685aae'

    [[Missing networks in account address, https://github.com//issues/20166]]

    Device sessions

    Passed tests (42)

    Click to expand

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    3. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_mentions_push_notification, id: 702786
    Device sessions

    3. test_community_leave, id: 702845
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_discovery, id: 703503
    Device sessions

    4. test_community_undo_delete_message, id: 702869
    Device sessions

    5. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    6. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    3. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    4. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    6. test_community_edit_delete_message_when_offline, id: 704615
    Device sessions

    7. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    8. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    9. test_community_message_edit, id: 702843
    Device sessions

    10. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613
    Device sessions

    2. test_links_deep_links, id: 702775
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    5. test_1_1_chat_edit_message, id: 702855
    Device sessions

    6. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    7. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    @flexsurfer flexsurfer moved this from E2E Tests to CONTRIBUTOR in Pipeline for QA Jun 27, 2024
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @qfrank qfrank qfrank approved these changes

    @Parveshdhull Parveshdhull Parveshdhull approved these changes

    @yqrashawn yqrashawn Awaiting requested review from yqrashawn

    Assignees

    @flexsurfer flexsurfer

    Labels
    request-manual-qa
    Projects
    Pipeline for QA
      
    CONTRIBUTOR
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Allow users from v1 to login with keycard Implement Pin Digit & Pin Input component
    4 participants
    @flexsurfer @status-im-auto @qfrank @Parveshdhull