Integrate Firebase for Android and iOS #21983
Open
+3,206
−329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (211)
|
seanstrom
force-pushed
the
seanstrom/firebase-integration
branch
6 times, most recently
from
e49478b to
ca8441e
Compare
seanstrom
force-pushed
the
seanstrom/firebase-integration
branch
3 times, most recently
from
5307db3 to
be2a8c2
Compare
seanstrom
force-pushed
the
seanstrom/firebase-integration
branch
3 times, most recently
from
4453b01 to
f58e51a
Compare
seanstrom
force-pushed
the
seanstrom/firebase-integration
branch
2 times, most recently
from
fb74c25 to
6c73939
Compare
seanstrom
changed the title
seanstrom
commented
Feb 24, 2025
Comment on lines
212
to
216
| build-fdroid: ##@build Build release for F-Droid | ||
| @scripts/google-free.sh | ||
| @scripts/build-android.sh | ||
|
|
There was a problem hiding this comment.
Here we're adding an additional script step for preparing an Android build for FDroid.
Comment on lines
+1
to
+11
| #!/usr/bin/env bash | ||
|
|
||
| set -e | ||
|
|
||
| # Used by Clojure to condition code and Gradle to make dependencies optional | ||
| sed -i -e '$aGOOGLE_FREE=1' .env.release | ||
|
|
||
| # remove firebase (uses google dependencies) and google-services.json for the fdroid-build | ||
| yarn remove @react-native-firebase/app | ||
| yarn remove @react-native-firebase/messaging | ||
| rm android/app/google-services.json |
There was a problem hiding this comment.
Here we're defining a cleanup script for the FDroid builds that removes Firebase dependencies and related files before continuing with building Android app for FDroid.
seanstrom
force-pushed
the
seanstrom/firebase-integration
branch
2 times, most recently
from
9173de4 to
a13ab31
Compare
ilmotta
reviewed
Mar 3, 2025
There was a problem hiding this comment.
@seanstrom, sorry for the long delay to review your PR. I can clearly see you put a lot of care into this PR 🌟 I did a first review pass, but haven't yet experimented with the branch.
I missed a few key unit tests to reason about the code. I think the low coverage rate will make the code fragile to future changes.
Comment on lines
+113
to
114
| <string>fetch</string> | ||
| </array> |
There was a problem hiding this comment.
I came across https://github.com/transistorsoft/react-native-background-fetch, which is much more actively developed compared to the lib we use react-native-background-timer (may or may not be a good thing). I'm not sure if or how they overlap in terms of capabilities.
src/legacy/status_im/ui/screens/notifications_settings/events.cljs
Outdated
Show resolved
Hide resolved
src/legacy/status_im/ui/screens/notifications_settings/events.cljs
Outdated
Show resolved
Hide resolved
src/legacy/status_im/ui/screens/notifications_settings/views.cljs
Outdated
Show resolved
Hide resolved
| "Request the remote token for the mobile platform. | ||
| On iOS this will retrieve a APNS token, | ||
| and on Android this will retrieve a FCM token." | ||
| [options] |
There was a problem hiding this comment.
I might've missed something in the PR, but I've seen many functions receiving and passing around an options map, but functions like start-registration and others ignore the parameter. Could you elaborate further on why we need for this parameter?
There was a problem hiding this comment.
I've sorta reserved the first argument to be a parameters map for these functions since I thought it'd be likely we would pass some flags or configuration at some point. Though atm, we currently don't really use it so it could be removed.
There was a problem hiding this comment.
Leaving here for future reference: we agreed off-GH to keep the options parameter and in case it proves to be unnecessary in the future we would try to remove the parameter.
seanstrom
force-pushed
the
seanstrom/firebase-integration
branch
4 times, most recently
from
dc17e6b to
0286e04
Compare
…tions instead of local and remote
seanstrom
force-pushed
the
seanstrom/firebase-integration
branch
from
0cf7bf8 to
d89661a
Compare
mohsen-ghafouri
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #22090
resolves #22174
resolves #22096
related status-go pr: status-im/status-go#6446
Summary
Review notes
make cleanbefore rebuilding the app.Testing notes
Platforms
Areas that may be impacted
Functional
Steps to test
WIP
status: ready