Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add transparent background option to <Avatar type="account" /> #617

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jkbktl
Copy link
Collaborator

@jkbktl jkbktl commented Oct 15, 2024

No description provided.

Copy link

changeset-bot bot commented Oct 15, 2024

🦋 Changeset detected

Latest commit: 56646cc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@status-im/components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Oct 15, 2024

@jkbktl is attempting to deploy a commit to the Status Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Oct 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
status-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 1:16pm

@prichodko
Copy link
Collaborator

Can you point me to Figma where this is reflected?

@jkbktl
Copy link
Collaborator Author

jkbktl commented Oct 15, 2024

Can you point me to Figma where this is reflected?

https://www.figma.com/design/WQZcp6S0EnzxdTL4taoKDv/Design-System-for-Mobile?node-id=483-19407&m=dev

@prichodko
Copy link
Collaborator

This is "Design System for Mobile". 🤔

@jkbktl
Copy link
Collaborator Author

jkbktl commented Oct 15, 2024

This is "Design System for Mobile". 🤔

Omg, didn't notice that, it's linked from Status Portfolio Figma though. https://www.figma.com/design/8IuYR751lsXg1F8bu8Cj8B/Status-Portfolio?node-id=1539-302342&m=dev

@marcelines
Copy link
Collaborator

Looking at figma, we can see that the design team are using a component from mobile's library.
image
image

And then looking at the use case in the design file, we can see a very different implementation. Will the design implement this variant of the component in our library? The selected state is different from ours. Line should be dashed.
image
image

@jkbktl
Copy link
Collaborator Author

jkbktl commented Oct 17, 2024

Looking at figma, we can see that the design team are using a component from mobile's library.

We expect that design will put this in order so our design system (for web) is in use. It doesn't necessarily have to be dashed, it might be solid, it depends on type of wallet (watched vs connected) as visible here in Figma, should be also visible in portfolio PR on different addresses.

This PR will be closed I guess.

@prichodko prichodko changed the title <AccountAvatar /> adds option to have transparent background add transparent background option to <Avatar type="account" /> Oct 18, 2024
@jkbktl jkbktl self-assigned this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants