Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If applied, this commit will add the package
blas/base/grot
Description
Add the package,
blas/base/grot
which serves as a generic JavaScript interface to handle array types such as numeric arrays and accessor arrays.Related Issues
This pull request:
blas/base/grot
#2190Questions
No.
Other
Use of
eslint-disable-line no-underscore-dangle
: This is used since we return the data buffer in case of an input accessor array.We are typecasting input arrays to accessor arrays while passing it to the grot function e.g.
Please do let me know in case it is preferred to cast it before it is passed as an argument e.g.
In accessor array implementation, we're using
@stdlib/complex/dtype
to find out the dtype of the input arrays and then conditionally setting it as a param for@stdlib/complex/cmplx
.Also, accessor array implementation works on one index at a time from each array similar to numeric array implementation but the complex array implementation works on 2 indexes from each array at a time since they're stored in pairs.
Tests pertaining to accessor arrays are bifurcated to numeric array tests, accessor array (complex) tests, and accessor array (real) tests.
Also, tests pertaining to accessor arrays testing if it applies plane rotation correctly have headings like :
tape( '...(sx=1, sy=1) (accessors - complex)', ....
. I'm not sure whether using parenthesis after parenthesis is the correct way.Checklist
@stdlib-js/reviewers