Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add blas/base/dznrm2 #2271

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

feat: add blas/base/dznrm2 #2271

wants to merge 5 commits into from

Conversation

aman-095
Copy link
Member

Description

What is the purpose of this pull request?

This RFC proposes to add a routine to find the euclidean norm of a complex double-precision floating-point vector as defined in BLAS Level 1 routines. Specifically adding @stdlib/blas/base/dznrm2 is proposed.

Related Issues

Does this pull request have any related issues?

None.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label May 27, 2024
@kgryte kgryte added Feature Issue or pull request for adding a new feature. Needs Changes Pull request which needs changes before being merged. labels Jun 8, 2024
kgryte
kgryte requested changes Jun 8, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking this PR as needing changes for similar reasons as #2270 .

@kgryte kgryte mentioned this pull request Jun 22, 2024
Merged
1 task
@kgryte
Copy link
Member

kgryte commented Jun 25, 2024

@aman-095 LMK when this PR is ready for review.

@aman-095 aman-095 marked this pull request as draft June 25, 2024 06:06
@aman-095 aman-095 marked this pull request as ready for review June 25, 2024 10:25
@aman-095
Copy link
Member Author

Hey, @kgryte, I have added C and Fortran implementation to this.

@aman-095 aman-095 added the Needs Review A pull request which needs code review. label Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Feature Issue or pull request for adding a new feature. Needs Changes Pull request which needs changes before being merged. Needs Review A pull request which needs code review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aman-095 @kgryte @stdlib-bot