Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add tests to @stdlib/ndarray/base/nullary #2350

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from
Open

test: add tests to @stdlib/ndarray/base/nullary #2350

wants to merge 14 commits into from

Conversation

headlessNode
Copy link
Contributor

Resolves #2229

Description

What is the purpose of this pull request?

This pull request:

  • adds tests for @stdlib/ndarray/base/nullary

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

I added some edge cases for blockednullary2d up to blockednullary4d (same for related complex data types) to get 100% coverage. But I don't know if I used the most feasible methods. I'd like some insight into that, thanks.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@headlessNode
test(ndarray/base/nullary): add tests for nullary0d
3538ad2
@headlessNode
test(ndarray/base/nullary): add tests for nullary1d
feeb626
@headlessNode
test(ndarray/base/nullary): add tests for nullary2d
cd48c03
@headlessNode
test(ndarray/base/nullary): add tests for nullary3d
8338c60
@headlessNode
test(ndarray/base/nullary): add tests for nullary4d
e536428
@headlessNode
test(ndarray/base/nullary): add tests for nullary5d
f3f5ca6
@headlessNode
test(ndarray/base/nullary): add tests for nullary6d
c422f32
@headlessNode
test(ndarray/base/nullary): add tests for nullary7d
0f87a70
@headlessNode
test(ndarray/base/nullary): add tests for nullary8d
f6c861b
@headlessNode
test(ndarray/base/nullary): add tests for nullary9d
e3f48e1
@headlessNode
test(ndarray/base/nullary): add tests for nullary10d
7b9aa26
@headlessNode
test(ndarray/base/nullary): add tests for nullarynd
3c14136
@headlessNode
test(ndarray/base/nullary): add some tests for edge-cases
ce16425
@headlessNode
chore(ndarray/base/nullary): remove fixme comment from test file
5fd1993
@kgryte kgryte added the Tests Pull requests specifically adding tests. label Jun 10, 2024
@headlessNode
Copy link
Contributor Author

@Planeshifter @kgryte Please review, thanks.

@kgryte kgryte added the Needs Review A pull request which needs code review. label Jun 22, 2024
@headlessNode
Copy link
Contributor Author

@kgryte @Planeshifter Ping, reminder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review A pull request which needs code review. Tests Pull requests specifically adding tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: add tests for @stdlib/ndarray/base/nullary
2 participants
@headlessNode @kgryte