Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update math/base/special/cabsf to follow latest project conventions #3358

Merged
merged 21 commits into from
Mar 24, 2025

Conversation

aayush0325
Copy link
Member

Resolves #3357

Description

What is the purpose of this pull request?

This pull request:

  • updates math/base/special/cabsf to follow latest project conventions

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

Sorry, something went wrong.

@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. labels Dec 7, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 7, 2024

Coverage Report

Package Statements Branches Functions Lines
math/base/special/cabsf 139 / 139
+ 100.00 %
5 / 5
+ 100.00 %
2 / 2
+ 100.00 %
139 / 139
+ 100.00 %

The above coverage report was generated for the changes in this PR.

@aayush0325
Copy link
Member Author

/stdlib help

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Dec 7, 2024
@stdlib-bot
Copy link
Contributor

@aayush0325, available slash commands include:

  • /stdlib check-files - Check for required files.
  • /stdlib update-copyright-years - Update copyright header years.
  • /stdlib lint-autofix - Auto-fix lint errors.
  • /stdlib merge - Merge changes from develop branch into this PR.
  • /stdlib rebase - Rebase this PR on top of develop branch.

@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Dec 7, 2024
@aayush0325
Copy link
Member Author

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Dec 7, 2024
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Dec 7, 2024
@aayush0325
Copy link
Member Author

i've cleared this branch from any unnecessary diff that was created while refactoring now @kgryte

@aayush0325 aayush0325 requested a review from kgryte December 16, 2024 16:06
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 16, 2024
@anandkaranubc anandkaranubc self-requested a review March 24, 2025 03:39
@anandkaranubc
Copy link
Contributor

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Mar 24, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Mar 24, 2025
@anandkaranubc
Copy link
Contributor

/stdlib merge

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Mar 24, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Mar 24, 2025
Copy link
Contributor

@anandkaranubc anandkaranubc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very few changes. Thank you for working on this!

Copy link
Contributor

@anandkaranubc anandkaranubc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kgryte, Whenever you have some time, could we get this one in? The C API is needed for the implementation of csignumf. No rush, thanks!

Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Mar 24, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Mar 24, 2025

PR Commit Message

feat!: update `math/base/special/cabsf` to follow latest project conventions

This commit updates the C API to operate on stdlib's single-precision complex number dtype.

BREAKING CHANGE: use stdlib C complex64 dtype

To migrate, users should provide a value having the type `stdlib_complex64_t`, rather than a built-in C99 single-precision complex dtype. This dtype is available via the package `@stdlib/complex/float32/ctor`.

PR-URL: https://github.com/stdlib-js/stdlib/pull/3358
Closes: https://github.com/stdlib-js/stdlib/issues/3357

Co-authored-by: stdlib-bot <noreply@stdlib.io>
Reviewed-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Karan Anand <119553199+anandkaranubc@users.noreply.github.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

@stdlib-bot stdlib-bot removed Needs Review A pull request which needs code review. Needs Changes Pull request which needs changes before being merged. labels Mar 24, 2025
@Planeshifter Planeshifter merged commit 42aab9b into stdlib-js:develop Mar 24, 2025
31 checks passed
sahil20021008 pushed a commit to sahil20021008/stdlib that referenced this pull request Mar 26, 2025
This commit updates the C API to operate on stdlib's single-precision complex number dtype.

BREAKING CHANGE: use stdlib C complex64 dtype

To migrate, users should provide a value having the type `stdlib_complex64_t`, rather than a built-in C99 single-precision complex dtype. This dtype is available via the package `@stdlib/complex/float32/ctor`.

PR-URL: stdlib-js#3358
Closes: stdlib-js#3357

Co-authored-by: stdlib-bot <noreply@stdlib.io>
Reviewed-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Karan Anand <119553199+anandkaranubc@users.noreply.github.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Math Issue or pull request specific to math functionality. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: refactor math/base/special/cabsf to follow latest project conventions.
5 participants