-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: update math/base/special/cabsf
to follow latest project conventions
#3358
Conversation
Coverage Report
The above coverage report was generated for the changes in this PR. |
/stdlib help |
@aayush0325, available slash commands include:
|
/stdlib update-copyright-years |
lib/node_modules/@stdlib/math/base/special/cabsf/benchmark/c/benchmark.c
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/cabsf/benchmark/c/benchmark.c
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/cabsf/benchmark/julia/benchmark.jl
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/cabsf/docs/types/index.d.ts
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/cabsf/docs/types/test.ts
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/cabsf/examples/c/Makefile
Outdated
Show resolved
Hide resolved
i've cleared this branch from any unnecessary diff that was created while refactoring now @kgryte |
/stdlib update-copyright-years |
/stdlib merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very few changes. Thank you for working on this!
lib/node_modules/@stdlib/math/base/special/cabsf/benchmark/c/native/benchmark.c
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/cabsf/benchmark/c/native/benchmark.c
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/cabsf/benchmark/c/native/benchmark.c
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/cabsf/benchmark/c/benchmark.c
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/cabsf/examples/c/example.c
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/cabsf/test/test.native.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kgryte, Whenever you have some time, could we get this one in? The C API is needed for the implementation of csignumf
. No rush, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
PR Commit Message
Please review the above commit message and make any necessary adjustments. |
This commit updates the C API to operate on stdlib's single-precision complex number dtype. BREAKING CHANGE: use stdlib C complex64 dtype To migrate, users should provide a value having the type `stdlib_complex64_t`, rather than a built-in C99 single-precision complex dtype. This dtype is available via the package `@stdlib/complex/float32/ctor`. PR-URL: stdlib-js#3358 Closes: stdlib-js#3357 Co-authored-by: stdlib-bot <noreply@stdlib.io> Reviewed-by: Athan Reines <kgryte@gmail.com> Reviewed-by: Karan Anand <119553199+anandkaranubc@users.noreply.github.com> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Resolves #3357
Description
This pull request:
math/base/special/cabsf
to follow latest project conventionsRelated Issues
This pull request:
math/base/special/cabsf
to follow latest project conventions. #3357Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers