Skip to content

docs: replace manual for loop in examples #6308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 24, 2025

Conversation

hrshya
Copy link
Contributor

@hrshya hrshya commented Mar 22, 2025

Resolves none .

Description

What is the purpose of this pull request?

This pull request:

  • replaces manual for loop in examples for math/base/special/besselj0, math/base/special/besselj1, math/base/special/bessely0, math/base/special/bessely1, math/base/special/betainc, math/base/special/betaincinv, math/base/special/binomcoef, and math/base/special/binomcoefln packages

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves no related issues.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

Sorry, something went wrong.

@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. labels Mar 22, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Mar 22, 2025

Coverage Report

Package Statements Branches Functions Lines
math/base/special/besselj0 491 / 501
+ 98.00 %
40 / 46
+ 86.96 %
6 / 6
+ 100.00 %
491 / 501
+ 98.00 %
math/base/special/besselj1 499 / 507
+ 98.42 %
42 / 48
+ 87.50 %
6 / 6
+ 100.00 %
499 / 507
+ 98.42 %
math/base/special/bessely0 586 / 599
+ 97.83 %
45 / 54
+ 83.33 %
7 / 7
+ 100.00 %
586 / 599
+ 97.83 %
math/base/special/bessely1 455 / 463
+ 98.27 %
39 / 45
+ 86.67 %
5 / 5
+ 100.00 %
455 / 463
+ 98.27 %
math/base/special/betainc 110 / 110
+ 100.00 %
7 / 7
+ 100.00 %
1 / 1
+ 100.00 %
110 / 110
+ 100.00 %
math/base/special/betaincinv 133 / 133
+ 100.00 %
14 / 14
+ 100.00 %
1 / 1
+ 100.00 %
133 / 133
+ 100.00 %
math/base/special/binomcoef 269 / 269
+ 100.00 %
34 / 34
+ 100.00 %
2 / 2
+ 100.00 %
269 / 269
+ 100.00 %
math/base/special/binomcoefln 217 / 217
+ 100.00 %
23 / 23
+ 100.00 %
2 / 2
+ 100.00 %
217 / 217
+ 100.00 %

The above coverage report was generated for the changes in this PR.

@hrshya
Copy link
Contributor Author

hrshya commented Mar 22, 2025

/stdlib lint-autofix

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Mar 22, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Mar 22, 2025
@kgryte kgryte added the Documentation Improvements, additions, or changes to documentation. label Mar 22, 2025
@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Mar 22, 2025
@hrshya hrshya requested a review from anandkaranubc March 24, 2025 08:56
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Mar 24, 2025
@hrshya hrshya requested a review from kgryte March 24, 2025 08:58
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Mar 24, 2025
@stdlib-bot stdlib-bot removed Needs Review A pull request which needs code review. Needs Changes Pull request which needs changes before being merged. labels Mar 24, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Mar 24, 2025

PR Commit Message

docs: replace manual `for` loop in examples

PR-URL: https://github.com/stdlib-js/stdlib/pull/6308

Co-authored-by: stdlib-bot <noreply@stdlib.io>
Reviewed-by: Athan Reines <kgryte@gmail.com> 
Reviewed-by: Karan Anand <119553199+anandkaranubc@users.noreply.github.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 75cbf89 into stdlib-js:develop Mar 24, 2025
49 checks passed
sahil20021008 pushed a commit to sahil20021008/stdlib that referenced this pull request Mar 26, 2025
PR-URL: stdlib-js#6308

Co-authored-by: stdlib-bot <noreply@stdlib.io>
Reviewed-by: Athan Reines <kgryte@gmail.com> 
Reviewed-by: Karan Anand <119553199+anandkaranubc@users.noreply.github.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
@hrshya hrshya deleted the fix/bern branch April 10, 2025 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements, additions, or changes to documentation. Math Issue or pull request specific to math functionality. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants